Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Log Driver] Add redis and kafka outputs #15719

Merged
merged 3 commits into from
Jan 23, 2020
Merged

[Elastic Log Driver] Add redis and kafka outputs #15719

merged 3 commits into from
Jan 23, 2020

Conversation

fearful-symmetry
Copy link
Contributor

So, I noticed that for some reason this isn't enabled. I'm not sure if this is a bug or enhancement, but I think we should have it in 7.6, as the rest of the beats have this and so should we.

I'm also not sure if anything is needed to get the cloud output working. Anyone know?

@fearful-symmetry fearful-symmetry added needs_backport PR is waiting to be backported to other branches. :integrations labels Jan 21, 2020
@fearful-symmetry fearful-symmetry requested a review from a team January 21, 2020 20:12
@fearful-symmetry fearful-symmetry self-assigned this Jan 21, 2020
exekias
exekias reviewed Jan 23, 2020
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, but I think these needs some tests. Now it's probably a good moment to invest some time on having a better test suite for this, including testing these outputs.

It will also need a changelog

sayden
sayden approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Carlos. I also think that tests could come in a follow up PR to keep things moving

@fearful-symmetry fearful-symmetry merged commit 1820369 into elastic:master Jan 23, 2020
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Jan 23, 2020
@fearful-symmetry
[Elastic Log Driver] Add redis and kafka outputs (elastic#15719)
eff5664 
* add redis and kafka out

* add cloud output

* add changelog

(cherry picked from commit 1820369)
@fearful-symmetry fearful-symmetry mentioned this pull request Jan 23, 2020
Merged
@fearful-symmetry fearful-symmetry added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 23, 2020
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Jan 23, 2020
@fearful-symmetry
[Elastic Log Driver] Add redis and kafka outputs (elastic#15719)
c0ce1f4 
* add redis and kafka out

* add cloud output

* add changelog

(cherry picked from commit 1820369)
@fearful-symmetry fearful-symmetry mentioned this pull request Jan 23, 2020
Merged
fearful-symmetry added a commit that referenced this pull request Jan 23, 2020
@fearful-symmetry
[Elastic Log Driver] Add redis and kafka outputs (#15719) (#15777)
4756a99 
* add redis and kafka out

* add cloud output

* add changelog

(cherry picked from commit 1820369)
fearful-symmetry added a commit that referenced this pull request Jan 24, 2020
@fearful-symmetry
Cherry-pick #15719 to 7.6: [Elastic Log Driver] Add redis and kafka o…
9aa6ef9 
…utputs (#15778)

* [Elastic Log Driver] Add redis and kafka outputs (#15719)

* add redis and kafka out

* add cloud output

* add changelog

(cherry picked from commit 1820369)

* fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias left review comments

@sayden sayden sayden approved these changes

Assignees

@fearful-symmetry fearful-symmetry

Labels
bug :integrations v7.6.0 v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fearful-symmetry @exekias @sayden