Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RFC3339 format for timestamps in SQL module #15847

Merged
merged 2 commits into from Jan 27, 2020
Merged

Use RFC3339 format for timestamps in SQL module #15847

merged 2 commits into from Jan 27, 2020

Conversation

jsoriano
Copy link
Member

What does this PR do?

Format timestamps collected with the SQL module using the RFC3339 Nano format,
that includes the timezone and is a more precise representation.

Why is it important?

So timezone information and precission is not lost when formatting the timestamps
for the final event.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@jsoriano
Use RFC3339 format for timestamps in SQL module
9a59a6f 
This way timezone and more precise information is stored in the final
events in case they are lately parsed as dates.
@jsoriano jsoriano added bug review needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Jan 25, 2020
@jsoriano jsoriano requested a review from a team as a code owner January 25, 2020 18:28
@jsoriano jsoriano self-assigned this Jan 25, 2020
@jsoriano jsoriano mentioned this pull request Jan 25, 2020
Merged
@jsoriano jsoriano merged commit 121f19d into elastic:master Jan 27, 2020
@jsoriano jsoriano deleted the fix-sql-date-format branch January 27, 2020 11:52
@jsoriano jsoriano mentioned this pull request Jan 27, 2020
Merged
5 tasks
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Jan 27, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Jan 27, 2020
@jsoriano
Use RFC3339 format for timestamps in SQL module (elastic#15847)
2fb8b1a 
This way timezone and more precise information is stored in the final
events in case they are lately parsed as dates.

(cherry picked from commit 121f19d)
jsoriano added a commit to jsoriano/beats that referenced this pull request Jan 27, 2020
@jsoriano
Use RFC3339 format for timestamps in SQL module (elastic#15847)
b91e9b0 
This way timezone and more precise information is stored in the final
events in case they are lately parsed as dates.

(cherry picked from commit 121f19d)
@jsoriano jsoriano mentioned this pull request Jan 27, 2020
Merged
5 tasks
jsoriano added a commit that referenced this pull request Jan 27, 2020
@jsoriano
Use RFC3339 format for timestamps in SQL module (#15847) (#15855)
a7c3591 
This way timezone and more precise information is stored in the final
events in case they are lately parsed as dates.

(cherry picked from commit 121f19d)
jsoriano added a commit that referenced this pull request Jan 27, 2020
@jsoriano
Use RFC3339 format for timestamps in SQL module (#15847) (#15856)
edcf872 
This way timezone and more precise information is stored in the final
events in case they are lately parsed as dates.

(cherry picked from commit 121f19d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@jsoriano jsoriano

Labels
bug review Team:Integrations Label for the Integrations team v7.6.0 v7.6.1 v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsoriano @mtojek