Validate mysql hosts during -configtest #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enhances the mysql-status MetricSet to validate the DSN (data source name) when it is constructed which occurs during -configtest. Previously an invalid DSN would not be detected until after the MetricSet was started and it would continuously send error events. It adds a connect, read, and write timeout to the mysql connection.
| @@ -45,8 +45,9 @@ type MetricSet struct { | |||
| func New(base mb.BaseMetricSet) (mb.MetricSet, error) { | |||
| // Unpack additional configuration options. | |||
| config := struct { | |||
| Username string `config:"username"` | |||
| Password string `config:"password"` | |||
| Hosts []string `config:"hosts" validate:"nonzero,required"` | |||
There was a problem hiding this comment.
That was only added for validation of Hosts? That would probably something that should be done on the module level as it applies to all mysql metricset (yes, there is currently only one) :-)
|
See my comment above, that can be discussed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the mysql-status MetricSet to validate the DSN (data source name)
when it is constructed which occurs during -configtest. Previously an invalid DSN
would not be detected until after the MetricSet was started and it would continuously
send error events.
It adds a connect, read, and write timeout to the mysql connection.