Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Add missing queue_url var definition in manifest.yml #16640

Merged
merged 2 commits into from
Feb 27, 2020
Merged

[Filebeat] Add missing queue_url var definition in manifest.yml #16640

merged 2 commits into from
Feb 27, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

What does this PR do?

This PR is to add queue_url definition in all manifest.yml for all aws Filebeat filesets.

Why is it important?

When running ./filebeat setup --modules aws command, this error showed up:

Exiting: Error getting config for fileset aws/cloudtrail: Error interpreting the template of the input: template: text:4:14: executing "text" at <.queue_url>: map has no entry for key "queue_url"

With this PR, rerun the same command:

(python-env) kaiyansheng@KaiyanMacBookPro:~/go/src/github.com/elastic/beats/x-pack/filebeat (aws_var)$ ./filebeat setup --modules aws
Overwriting ILM policy is disabled. Set `setup.ilm.overwrite:true` for enabling.

Index setup finished.
Loading dashboards (Kibana must be running and reachable)
Skipping loading dashboards, No directory /Users/kaiyansheng/go/src/github.com/elastic/beats/x-pack/filebeat/kibana/7
Loaded Ingest pipelines

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner February 26, 2020 20:40
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 26, 2020
@kaiyan-sheng kaiyan-sheng added bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Feb 26, 2020
mtojek
mtojek approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 3a764e6 into elastic:master Feb 27, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Feb 27, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.6.1 v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 27, 2020
kaiyan-sheng added a commit that referenced this pull request Feb 27, 2020
@kaiyan-sheng
[Filebeat] Add missing queue_url var definition in manifest.yml (#16640…
17b1cb3 
…) (#16664)

* Missing queue_url in aws module manifest.yml

* update changelog

(cherry picked from commit 3a764e6)
@kaiyan-sheng kaiyan-sheng deleted the aws_var branch February 27, 2020 16:29
kaiyan-sheng added a commit that referenced this pull request Feb 27, 2020
@kaiyan-sheng
Cherry-pick #16640 to 7.6: [Filebeat] Add missing queue_url var defin…
11d7f95 
…ition in manifest.yml (#16665)

* [Filebeat] Add missing queue_url var definition in manifest.yml (#16640)

* Missing queue_url in aws module manifest.yml

* update changelog

(cherry picked from commit 3a764e6)

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

@narph narph Awaiting requested review from narph

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
bug Filebeat Filebeat review Team:Platforms Label for the Integrations - Platforms team v7.6.1 v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaiyan-sheng @mtojek @andresrc