Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #15503 to 7.x: Move pdh query to shared location in order for new modules/metricsets to reuse #16722

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 2, 2020

Cherry-pick of PR #15503 to 7.x branch. Original message:

The pdh windows query implementation is currently at the windows/perfmon metricset level.
This functionality can be reused by future modules/metricsets as the iis module, active directory metricset.
#13072
#14836

… to reuse (elastic#15503)

* Move pdh query to shared location

* Update changelog

* Fix make update

* mage fmt

* fix changelog

(cherry picked from commit 2657f71)
@narph narph requested a review from a team as a code owner March 2, 2020 09:30
@narph narph self-assigned this Mar 2, 2020
@narph narph added backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team [zube]: In Review labels Mar 2, 2020
@narph narph merged commit 7884758 into elastic:7.x Mar 2, 2020
@narph narph deleted the backport_15503_7.x branch March 2, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants