Cherry-pick #16288 to 7.x: Fix generator jobs for go modules #16828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set the correct path to `mage` for generator jobs
* Generated beats use go modules for dependency management
* New option `beats_revision` is added so users can select which beats revision they want to vendor
* if one does not want to depend on `elastic/beats`, he/she needs to add the appropriate `replace` directive to the generated `go.mod`
As Beats is moving to go modules for dependency management, generated Beats should use that as well.
Documentation is provided to help users migrate to go modules in their own Beats. Also, about the new option.
(cherry picked from commit a846029)
kvch
added
[zube]: In Review
backport
Team:Services
michalpristas
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16288 to 7.x branch. Original message:
What does this PR do?
magefor generator jobsbeats_revisionis added so users can select which beats revision they want to vendorelastic/beats, he/she needs to add the appropriatereplacedirective to the generatedgo.modWhy is it important?
As Beats is moving to go modules for dependency management, generated Beats should use that as well.
Documentation is provided to help users migrate to go modules in their own Beats. Also, about the new option.
Checklist