Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17095 to 7.x: Fix cisco-ftd test case for new behavior of lowercase processor #17115

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 19, 2020

Warn: Do not merge until the problem appears in 7.x branch.
See Logs below for the problem this fixes.


Cherry-pick of PR #17095 to 7.x branch. Original message:

What does this PR do?

Updates the golden files for Filebeat's cisco/ftd fileset to adapt to the new behavior of ingest node's lowercase processor after elastic/elasticsearch#53343

Why is it important?

So that integration tests pass when run against an Elasticsearch that contains the changes linked above.

Logs

Error fixed by this:

test_xpack_modules.XPackTest.test_fileset_file_065_cisco

AssertionError: The following expected object doesn't match:
 Diff:
{'iterable_item_added': {"root['network.application'][0]": 'advanced packaging tool', "root['network.application'][1]": 'ubuntu'}, 'iterable_item_removed': {"root['network.application'][1]": 'Ubuntu', "root['network.application'][0]": 'Advanced Packaging Tool'}}, full object:
[...]

After elastic/elasticsearch#53343, ingest node's lowercase processor
will lowercase values in arrays. This is causing the integration tests
to fail.

(cherry picked from commit 0731f45)
@adriansr adriansr merged commit 06c4a4b into elastic:7.x Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants