Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for deploying filebeat and metricbeat in Cloud Foundry. #17275

Merged
merged 6 commits into from
Mar 27, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Mar 27, 2020

What does this PR do?

Adds documentation on running filebeat and metricbeat inside of Cloud Foundry.

Why is it important?

Because almost all operators of Cloud Foundry will want to deploy it inside of the foundation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Follow the instructions to ensure it results in a running filebeat and metricbeat inside of Cloud Foundry.

Related issues

@blakerouse blakerouse changed the title Docs deploy into cf Add documentation for deploying filebeat and metricbeat in Cloud Foundry. Mar 27, 2020
@blakerouse blakerouse requested a review from a team March 27, 2020 02:17
@blakerouse blakerouse added the Team:Platforms Label for the Integrations - Platforms team label Mar 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me! trusting you on the cf commands as I'm not familiar with them

@exekias exekias added docs needs_backport PR is waiting to be backported to other branches. labels Mar 27, 2020
Copy link
Contributor

@bvader bvader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.
One question you are using the the yml "anchors / shorthand" is that OK per our standard?

@blakerouse
Copy link
Contributor Author

@bvader I don't know about standard in that case, but the yaml anchors are fully supported by the yaml parsing module used by beats and it makes updating the configuration a lot simpler. In this case I think its worth it.

@blakerouse blakerouse merged commit 850d1fa into elastic:master Mar 27, 2020
@blakerouse blakerouse deleted the docs-deploy-into-cf branch March 27, 2020 17:55
@blakerouse blakerouse added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 27, 2020
blakerouse added a commit to blakerouse/beats that referenced this pull request Mar 31, 2020
…dry. (elastic#17275)

* Add running-on-cloudfoundry for filebeat.

* Fix typo.

* Add running on cloudfoundry for metricbeat.

* Add changelog.

* Add missing newline at end of metricbeat manifest.

* Fix filebeat being referenced in metricbeat docs.

(cherry picked from commit 850d1fa)
blakerouse added a commit that referenced this pull request Mar 31, 2020
…dry. (#17275) (#17299)

* Add running-on-cloudfoundry for filebeat.

* Fix typo.

* Add running on cloudfoundry for metricbeat.

* Add changelog.

* Add missing newline at end of metricbeat manifest.

* Fix filebeat being referenced in metricbeat docs.

(cherry picked from commit 850d1fa)
blakerouse added a commit to blakerouse/beats that referenced this pull request Apr 3, 2020
…dry. (elastic#17275)

* Add running-on-cloudfoundry for filebeat.

* Fix typo.

* Add running on cloudfoundry for metricbeat.

* Add changelog.

* Add missing newline at end of metricbeat manifest.

* Fix filebeat being referenced in metricbeat docs.

(cherry picked from commit 850d1fa)
blakerouse added a commit that referenced this pull request Apr 3, 2020
…dry. (#17275) (#17298)

* Add running-on-cloudfoundry for filebeat.

* Fix typo.

* Add running on cloudfoundry for metricbeat.

* Add changelog.

* Add missing newline at end of metricbeat manifest.

* Fix filebeat being referenced in metricbeat docs.

(cherry picked from commit 850d1fa)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…dry. (elastic#17275) (elastic#17299)

* Add running-on-cloudfoundry for filebeat.

* Fix typo.

* Add running on cloudfoundry for metricbeat.

* Add changelog.

* Add missing newline at end of metricbeat manifest.

* Fix filebeat being referenced in metricbeat docs.

(cherry picked from commit e29d929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Platforms Label for the Integrations - Platforms team v7.7.0 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants