Fix initialization of Logstash service URL #17497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
needs_backport
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
|
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
added
v7.7.1
test-plan
ycombinator
force-pushed
the
mb-ls-xp-init-bugfix
branch
from
7fe3afc
to
52aafd9
Compare
zube
bot
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
ycombinator
force-pushed
the
mb-ls-xp-init-bugfix
branch
from
9401060
to
f4c4fd4
Compare
|
CI failures are unrelated. Merging. |
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Apr 7, 2020
* Fix initialization of Logstash service URL * Adding CHANGELOG entry * Expose Logstash HTTP API port in local environment * Remove once field as it is no longer used * Encapsulating more logic into method * Debugging * Compare cluster UUIDs * Adding ES service * Adding default LS pipeline that outputs to ES cluster * Use beats input so LS pipeline (and node) keeps running * Fixing up ES config in docker compose file * Handle errors * Fixing typo * COPY pipeline file as part of image * Refactoring code to make testable + Adding unit tests * Adding comment for test * Fixing URIs
This was referenced Apr 7, 2020
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Apr 7, 2020
* Fix initialization of Logstash service URL * Adding CHANGELOG entry * Expose Logstash HTTP API port in local environment * Remove once field as it is no longer used * Encapsulating more logic into method * Debugging * Compare cluster UUIDs * Adding ES service * Adding default LS pipeline that outputs to ES cluster * Use beats input so LS pipeline (and node) keeps running * Fixing up ES config in docker compose file * Handle errors * Fixing typo * COPY pipeline file as part of image * Refactoring code to make testable + Adding unit tests * Adding comment for test * Fixing URIs
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Apr 8, 2020
* Fix initialization of Logstash service URL * Adding CHANGELOG entry * Expose Logstash HTTP API port in local environment * Remove once field as it is no longer used * Encapsulating more logic into method * Debugging * Compare cluster UUIDs * Adding ES service * Adding default LS pipeline that outputs to ES cluster * Use beats input so LS pipeline (and node) keeps running * Fixing up ES config in docker compose file * Handle errors * Fixing typo * COPY pipeline file as part of image * Refactoring code to make testable + Adding unit tests * Adding comment for test * Fixing URIs
ycombinator
added a commit
that referenced
this pull request
Apr 8, 2020
* Fix initialization of Logstash service URL * Adding CHANGELOG entry * Expose Logstash HTTP API port in local environment * Remove once field as it is no longer used * Encapsulating more logic into method * Debugging * Compare cluster UUIDs * Adding ES service * Adding default LS pipeline that outputs to ES cluster * Use beats input so LS pipeline (and node) keeps running * Fixing up ES config in docker compose file * Handle errors * Fixing typo * COPY pipeline file as part of image * Refactoring code to make testable + Adding unit tests * Adding comment for test * Fixing URIs
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Apr 8, 2020
* Fix initialization of Logstash service URL * Adding CHANGELOG entry * Expose Logstash HTTP API port in local environment * Remove once field as it is no longer used * Encapsulating more logic into method * Debugging * Compare cluster UUIDs * Adding ES service * Adding default LS pipeline that outputs to ES cluster * Use beats input so LS pipeline (and node) keeps running * Fixing up ES config in docker compose file * Handle errors * Fixing typo * COPY pipeline file as part of image * Refactoring code to make testable + Adding unit tests * Adding comment for test * Fixing URIs
ycombinator
added a commit
that referenced
this pull request
Apr 9, 2020
* Fix initialization of Logstash service URL (#17497) * Fix initialization of Logstash service URL * Adding CHANGELOG entry * Expose Logstash HTTP API port in local environment * Remove once field as it is no longer used * Encapsulating more logic into method * Debugging * Compare cluster UUIDs * Adding ES service * Adding default LS pipeline that outputs to ES cluster * Use beats input so LS pipeline (and node) keeps running * Fixing up ES config in docker compose file * Handle errors * Fixing typo * COPY pipeline file as part of image * Refactoring code to make testable + Adding unit tests * Adding comment for test * Fixing URIs * CHANGELOG grooming * Removing assert
6 tasks
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…7592) * Fix initialization of Logstash service URL * Adding CHANGELOG entry * Expose Logstash HTTP API port in local environment * Remove once field as it is no longer used * Encapsulating more logic into method * Debugging * Compare cluster UUIDs * Adding ES service * Adding default LS pipeline that outputs to ES cluster * Use beats input so LS pipeline (and node) keeps running * Fixing up ES config in docker compose file * Handle errors * Fixing typo * COPY pipeline file as part of image * Refactoring code to make testable + Adding unit tests * Adding comment for test * Fixing URIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the initialization of the Logstash service's URI in the
logstash/node_statsmetricset.Why is it important?
Prior to this fix, when the
logstash-xpackMetricbeat module was enabled, users would need to start up Metricbeat after Logstash was started up in order for thelogstash/node_statsmetricset to report the correct data.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues