Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] add more metric collection into pubsub metricset #17600

Merged
merged 7 commits into from
Apr 9, 2020
Merged

[Metricbeat] add more metric collection into pubsub metricset #17600

merged 7 commits into from
Apr 9, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 8, 2020 •
edited

What does this PR do?

This PR is to add more metric collection into pubsub metricset for subscription and topic. Also added all metrics for snapshot.

Why is it important?

This gives a full picture for gcp pubsub data collection, which matches what stackdriver has.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

#17154

@kaiyan-sheng kaiyan-sheng self-assigned this Apr 8, 2020
@kaiyan-sheng kaiyan-sheng added Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team labels Apr 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@kaiyan-sheng kaiyan-sheng added the in progress Pull request is currently in progress. label Apr 8, 2020
@kaiyan-sheng kaiyan-sheng added [zube]: In Review needs_backport PR is waiting to be backported to other branches. review and removed in progress Pull request is currently in progress. labels Apr 8, 2020
@kaiyan-sheng kaiyan-sheng requested a review from sayden April 8, 2020 21:35
blakerouse
blakerouse approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on pubsub, but overall the branch looks correct. Don't see any issues that stand out to me.

@kaiyan-sheng
Copy link
Contributor Author

CI failed with error 13:31:58 metricset_test.go:21: failed to start service 'oracle: exit status 1. Not related to this PR.

@kaiyan-sheng kaiyan-sheng merged commit 50c6e86 into elastic:master Apr 9, 2020
@kaiyan-sheng kaiyan-sheng deleted the pubsub_metrics branch April 9, 2020 19:55
@kaiyan-sheng kaiyan-sheng mentioned this pull request Apr 9, 2020
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 9, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Apr 9, 2020
Merged
6 tasks
kaiyan-sheng added a commit that referenced this pull request Apr 10, 2020
@kaiyan-sheng
[Metricbeat] add more metric collection into pubsub metricset (#17600) (
7a46b8b 
#17652)

* add more metric collection into pubsub metricset
* fix docs.asciidoc for pubsub

(cherry picked from commit 50c6e86)
kaiyan-sheng added a commit that referenced this pull request Apr 12, 2020
@kaiyan-sheng
[Metricbeat] add more metric collection into pubsub metricset (#17600) (
f42e2fe 
#17651)

* add more metric collection into pubsub metricset
* fix docs.asciidoc for pubsub

(cherry picked from commit 50c6e86)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng
[Metricbeat] add more metric collection into pubsub metricset (elasti…
9d73586 
…c#17600) (elastic#17652)

* add more metric collection into pubsub metricset
* fix docs.asciidoc for pubsub

(cherry picked from commit 63e38d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@sayden sayden Awaiting requested review from sayden

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Metricbeat Metricbeat review Team:Platforms Label for the Integrations - Platforms team v7.7.0 v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kaiyan-sheng @elasticmachine @blakerouse @andresrc