Handle ECS-compatible slowlogs emitted by ES 8.0.0+ #17729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ycombinator
added
Feature:Stack Monitoring
Team:Services
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
|
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
added
[zube]: In Review
needs_backport
ycombinator
force-pushed
the
fb-es-slowlog-800-ecs
branch
from
7dc8e90
to
a87d58e
Compare
|
Travis CI is green and Jenkins CI failures are unrelated. Merging. |
ycombinator
removed
the
needs_backport
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Apr 24, 2020
* Adding ECS-compatible sample slowlogs * Handle ECS-compatible slowlogs emitted by ES 8.0.0+ * Adding CHANGELOG entry
ycombinator
added a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With elastic/elasticsearch#47105 merged, starting with 8.0.0, Elasticsearch will emit ECS-compatible slowlogs (and other types of logs). This PR enhances the
elasticsearch/slowlogfileset's ingestion pipeline to handle this new slowlog format, while also remaining backwards-compatible with the previous (7.x) slowlog format.Why is it important?
So the Filebeat
elasticsearch/slowlogfileset can handle current as well as upcoming Elasticsearch slowlog formats.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues