Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Add support for v10, v11 and v12 Postgres logs with duration statement #17732

Merged
merged 11 commits into from
May 5, 2020
Merged

[Filebeat] Add support for v10, v11 and v12 Postgres logs with duration statement #17732

merged 11 commits into from
May 5, 2020

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Apr 15, 2020 •
edited
Loading

Fixes #13810

Logs provided in the previous issue aren't default logs for Postgres v10. However the difference is very subtle and I managed to give support to default logs and logs with log_min_duration_statement = 0 wich activates logging of the duration of all statements.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@sayden sayden added enhancement Filebeat Filebeat Team:Services (Deprecated) Label for the former Integrations-Services team labels Apr 15, 2020
@sayden sayden self-assigned this Apr 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@sayden sayden marked this pull request as ready for review April 15, 2020 16:29
@sayden sayden changed the title [Filebeat] Add support for v10 Postgres logs with duration statement [Filebeat] Add support for v10, v11 and v12 Postgres logs with duration statement Apr 16, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 5, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [sayden commented: jenkins run the tests please]

  • Start Time: 2020-05-05T13:44:22.734+0000

  • Duration: 59 min 31 sec (3510828)

  • Commit: d47f610

Test stats 🧪

Test Results
Failed 0
Passed 2773
Skipped 418
Total 3191

@sayden
Copy link
Contributor Author

sayden commented May 5, 2020

jenkins run the tests please

@sayden sayden merged commit a9d510c into elastic:master May 5, 2020
sayden added a commit to sayden/beats that referenced this pull request May 5, 2020
@sayden
[Filebeat] Add support for v10, v11 and v12 Postgres logs with durati…
fa6df55 
…on statement (elastic#17732)

(cherry picked from commit a9d510c)
@sayden sayden mentioned this pull request May 5, 2020
Merged
6 tasks
@sayden sayden added the v7.8.0 label May 5, 2020
sayden added a commit that referenced this pull request May 5, 2020
@sayden
Cherry-pick #17732 to 7.x: [Filebeat] Add support for v10, v11 and v1…
2054d3d 
…2 Postgres logs with duration statement (#18253)
@sayden sayden deleted the feature/fb/postgres/v-10-support branch August 25, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees

@sayden sayden

Labels
enhancement Filebeat Filebeat Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] Add support for postgresql version 10 logs
4 participants
@sayden @elasticmachine @kvch @andresrc