Add fields validation for histogram subfields #17759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation to histogram subfields in a way that they don't need to be added to the mappings, but they can still be checked. This is helpful to avoid having to add exceptions to all the modules based on Prometheus when Elasticsearch types are used.
jsoriano
added
enhancement
review
needs_backport
11 tasks
|
Failure in libbeat is #17768, failures in Mac OS X don't seem related. |
|
jenkins, test this again. |
|
jenkins, test this again please |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 17, 2020
Add validation to histogram subfields in a way that they don't need to be added to the mappings, but they can still be checked. This is helpful to avoid having to add exceptions to all the modules based on Prometheus when Elasticsearch types are used. (cherry picked from commit 5983411)
6 tasks
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 17, 2020
Add validation to histogram subfields in a way that they don't need to be added to the mappings, but they can still be checked. This is helpful to avoid having to add exceptions to all the modules based on Prometheus when Elasticsearch types are used. (cherry picked from commit 5983411)
6 tasks
jsoriano
added a commit
that referenced
this pull request
Apr 21, 2020
Add validation to histogram subfields in a way that they don't need to be added to the mappings, but they can still be checked. This is helpful to avoid having to add exceptions to all the modules based on Prometheus when Elasticsearch types are used. (cherry picked from commit 5983411)
jsoriano
added a commit
that referenced
this pull request
Apr 21, 2020
…lds (#17786) Add validation to histogram subfields in a way that they don't need to be added to the mappings, but they can still be checked. This is helpful to avoid having to add exceptions to all the modules based on Prometheus when Elasticsearch types are used. (cherry picked from commit 5983411)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… subfields (elastic#17786) Add validation to histogram subfields in a way that they don't need to be added to the mappings, but they can still be checked. This is helpful to avoid having to add exceptions to all the modules based on Prometheus when Elasticsearch types are used. (cherry picked from commit 4912b78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.
Why is it important?
To avoid needing to add exceptions or additional mappings to the Prometheus
module or to modules based on it (as in #17736).
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues