Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL filebeat: Define fields.epr.yml #17895

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Apr 22, 2020

This PR defines additional fields referenced in the ingest pipeline.

The file is used by the import-beats script to include them in integration packages.

@mtojek mtojek requested review from ruflin and a team April 22, 2020 11:35
@mtojek mtojek self-assigned this Apr 22, 2020
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you double check that this file is ignored in all of the build process around collecting fields.yml files?

@mtojek
Copy link
Contributor Author

mtojek commented Apr 22, 2020

LGTM.

Could you double check that this file is ignored in all of the build process around collecting fields.yml files?

$ mage update
grep -rn "Event kind" .
./module/mysql/error/_meta/fields.epr.yml:15:  description: Event kind (e.g. event)
$ mage fields
grep -rn "Event kind" .
./module/mysql/error/_meta/fields.epr.yml:15:  description: Event kind (e.g. event)

I think it's not touched by any process.

@mtojek mtojek merged commit 0abcaf2 into elastic:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants