Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Fix default configuration after enroll #18232

Merged
merged 3 commits into from May 5, 2020
Merged

[Elastic Agent] Fix default configuration after enroll #18232

merged 3 commits into from May 5, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 5, 2020 •
edited

What does this PR do?

Changes default configuration after enroll so agent is not in standalone mode

Why is it important?

To switch behavior from standalone to enroll

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

cc @ruflin @ph

@michalpristas michalpristas added bug Project:fleet Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 5, 2020
@michalpristas michalpristas self-assigned this May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
ruflin
ruflin approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. What I wonder is why it worked before? Did this just break recently?

@michalpristas
Copy link
Contributor Author

related to configuration changes pushed in yesterday where we commented out all the options across codebase

@michalpristas michalpristas removed the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
@ruflin
Copy link
Member

ruflin commented May 5, 2020

@michalpristas I assume in the end, no config is needed and we will have this default also in the code base?

@michalpristas
Copy link
Contributor Author

yes that would be nice and we would avoid situations like this during bulk editing

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 5, 2020 •
edited

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@michalpristas michalpristas merged commit d7fbc77 into elastic:master May 5, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 5, 2020
@michalpristas
[Elastic Agent] Fix default configuration after enroll (elastic#18232)
796291f 
* fix enroll

* changelog

* changelog
@michalpristas michalpristas added the needs_backport PR is waiting to be backported to other branches. label May 5, 2020
@michalpristas michalpristas mentioned this pull request May 5, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request May 5, 2020
@michalpristas
[Elastic Agent] Fix default configuration after enroll (#18232) (#18238)
38b2ee8 
* fix enroll

* changelog

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalpristas @elasticmachine @ruflin