Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding observer.zone/interface following ECS 1.5.0 #18600

Closed
wants to merge 1 commit into from
Closed

adding observer.zone/interface following ECS 1.5.0 #18600

wants to merge 1 commit into from

Conversation

dainok
Copy link
Contributor

@dainok dainok commented May 16, 2020

What does this PR do?

Added observer.[e|in]gress.zone and observer.[e|in]gress.interface.name

Why is it important?

observer.zone is defined on ECS 1.5.0

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Use cases

The fix adds observer elements and doesn't remove anything.
BTW panw.panos.source.zone, panw.panos.destination.zone, panw.panos.source.interface and panw.panos.destination.interface can be now removed.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 18, 2020
@dainok dainok requested review from a team as code owners June 4, 2020 14:50
@botelastic botelastic bot added the Team:Automation Label for the Observability productivity team label Jun 4, 2020
@andrewkroh
Copy link
Member

jenkins, run tests

@andrewkroh andrewkroh added ecs enhancement Filebeat Filebeat review and removed Team:Automation Label for the Observability productivity team labels Jun 4, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 4, 2020 •
edited

❕ Build Aborted

The PR is not allowed to run in the CI yet

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18600 updated]

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2020-06-04T15:28:32.482+0000

  • Duration: 3 min 25 sec

  • Commit: 411de5c

Steps errors

Expand to view the steps failures

  • Name: Error signal

    • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

    • Duration: 0 min 0 sec

    • Start Time: 2020-06-04T15:31:52.763+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-06-04T15:31:54.568Z] Stage "Elastic Agent x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:54.569Z] Stage "Elastic Agent x-pack Windows" skipped due to earlier failure(s)
[2020-06-04T15:31:54.570Z] Stage "Elastic Agent Mac OS X" skipped due to earlier failure(s)
[2020-06-04T15:31:54.571Z] Stage "Filebeat oss" skipped due to earlier failure(s)
[2020-06-04T15:31:54.572Z] Stage "Filebeat x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:54.573Z] Stage "Filebeat Mac OS X" skipped due to earlier failure(s)
[2020-06-04T15:31:54.573Z] Stage "Filebeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-06-04T15:31:54.574Z] Stage "Filebeat Windows" skipped due to earlier failure(s)
[2020-06-04T15:31:54.575Z] Stage "Filebeat x-pack Windows" skipped due to earlier failure(s)
[2020-06-04T15:31:54.576Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.577Z] Stage "Auditbeat oss Linux" skipped due to earlier failure(s)
[2020-06-04T15:31:54.578Z] Stage "Auditbeat crosscompile" skipped due to earlier failure(s)
[2020-06-04T15:31:54.579Z] Stage "Auditbeat oss Mac OS X" skipped due to earlier failure(s)
[2020-06-04T15:31:54.580Z] Stage "Auditbeat oss Windows" skipped due to earlier failure(s)
[2020-06-04T15:31:54.581Z] Stage "Auditbeat x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:54.582Z] Stage "Auditbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-06-04T15:31:54.583Z] Stage "Auditbeat x-pack Windows" skipped due to earlier failure(s)
[2020-06-04T15:31:54.584Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.584Z] Stage "Libbeat x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:54.586Z] Stage "Metricbeat OSS Unit tests" skipped due to earlier failure(s)
[2020-06-04T15:31:54.587Z] Stage "Metricbeat OSS Integration tests" skipped due to earlier failure(s)
[2020-06-04T15:31:54.588Z] Stage "Metricbeat Python integration tests" skipped due to earlier failure(s)
[2020-06-04T15:31:54.589Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:54.590Z] Stage "Metricbeat crosscompile" skipped due to earlier failure(s)
[2020-06-04T15:31:54.591Z] Stage "Metricbeat Mac OS X" skipped due to earlier failure(s)
[2020-06-04T15:31:54.592Z] Stage "Metricbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-06-04T15:31:54.593Z] Stage "Metricbeat Windows" skipped due to earlier failure(s)
[2020-06-04T15:31:54.594Z] Stage "Metricbeat x-pack Windows" skipped due to earlier failure(s)
[2020-06-04T15:31:54.595Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.596Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.597Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.597Z] Stage "Winlogbeat Windows x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:54.599Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.599Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.600Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-04T15:31:54.601Z] Stage "Kubernetes" skipped due to earlier failure(s)
[2020-06-04T15:31:54.700Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.702Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.703Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:54.704Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.705Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.706Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.707Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.708Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:54.709Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-04T15:31:55.295Z] Failed in branch Elastic Agent x-pack
[2020-06-04T15:31:55.296Z] Failed in branch Elastic Agent x-pack Windows
[2020-06-04T15:31:55.297Z] Failed in branch Elastic Agent Mac OS X
[2020-06-04T15:31:55.298Z] Failed in branch Filebeat oss
[2020-06-04T15:31:55.299Z] Failed in branch Filebeat x-pack
[2020-06-04T15:31:55.300Z] Failed in branch Filebeat Mac OS X
[2020-06-04T15:31:55.300Z] Failed in branch Filebeat x-pack Mac OS X
[2020-06-04T15:31:55.301Z] Failed in branch Filebeat Windows
[2020-06-04T15:31:55.301Z] Failed in branch Filebeat x-pack Windows
[2020-06-04T15:31:55.302Z] Failed in branch Auditbeat oss Linux
[2020-06-04T15:31:55.303Z] Failed in branch Auditbeat crosscompile
[2020-06-04T15:31:55.303Z] Failed in branch Auditbeat oss Mac OS X
[2020-06-04T15:31:55.304Z] Failed in branch Auditbeat oss Windows
[2020-06-04T15:31:55.305Z] Failed in branch Auditbeat x-pack
[2020-06-04T15:31:55.305Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-06-04T15:31:55.306Z] Failed in branch Auditbeat x-pack Windows
[2020-06-04T15:31:55.307Z] Failed in branch Libbeat x-pack
[2020-06-04T15:31:55.307Z] Failed in branch Metricbeat OSS Unit tests
[2020-06-04T15:31:55.308Z] Failed in branch Metricbeat OSS Integration tests
[2020-06-04T15:31:55.308Z] Failed in branch Metricbeat Python integration tests
[2020-06-04T15:31:55.309Z] Failed in branch Metricbeat crosscompile
[2020-06-04T15:31:55.310Z] Failed in branch Metricbeat Mac OS X
[2020-06-04T15:31:55.310Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-06-04T15:31:55.311Z] Failed in branch Metricbeat Windows
[2020-06-04T15:31:55.311Z] Failed in branch Metricbeat x-pack Windows
[2020-06-04T15:31:55.312Z] Failed in branch Winlogbeat Windows x-pack
[2020-06-04T15:31:55.313Z] Failed in branch Kubernetes
[2020-06-04T15:31:55.597Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:55.599Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:55.600Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-06-04T15:31:55.601Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:55.602Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:55.604Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-04T15:31:55.668Z] Failed in branch Packetbeat
[2020-06-04T15:31:55.669Z] Failed in branch dockerlogbeat
[2020-06-04T15:31:55.670Z] Failed in branch Journalbeat
[2020-06-04T15:31:55.874Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:55.876Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:55.877Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-06-04T15:31:55.878Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-04T15:31:55.915Z] Failed in branch Metricbeat x-pack
[2020-06-04T15:31:55.916Z] Failed in branch Winlogbeat
[2020-06-04T15:31:56.113Z] Failed in branch Heartbeat
[2020-06-04T15:31:56.114Z] Failed in branch Libbeat
[2020-06-04T15:31:56.114Z] Failed in branch Functionbeat
[2020-06-04T15:31:56.115Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-04T15:31:56.187Z] Failed in branch Generators
[2020-06-04T15:31:56.482Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18600
[2020-06-04T15:31:56.587Z] [INFO] getVaultSecret: Getting secrets
[2020-06-04T15:31:56.645Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-06-04T15:31:57.396Z] + chmod 755 generate-build-data.sh
[2020-06-04T15:31:57.396Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18600/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18600/runs/4 ABORTED 204655
[2020-06-04T15:31:57.396Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18600/runs/4/steps/?limit=10000 -o steps-info.json
[2020-06-04T15:31:57.947Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18600/runs/4/tests/?status=FAILED -o tests-errors.json
[2020-06-04T15:31:57.947Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18600/runs/4/log/ -o pipeline-log.txt

@andrewkroh
Copy link
Member

These fields were added in #18525 so I'm closing this.

@andrewkroh andrewkroh closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ecs enhancement Filebeat Filebeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dainok @elasticmachine @andrewkroh @andresrc