Removing xpack.monitoring.* settings #18608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
ycombinator
added
breaking change
libbeat
Feature:Stack Monitoring
Team:Integrations
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
|
Pinging @elastic/integrations (Team:Integrations) |
ycombinator
added
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
urso
approved these changes
May 18, 2020
|
These kind of PRs I like :) |
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
ycombinator
force-pushed
the
del-xpack-monitoring
branch
3 times, most recently
from
464da97
to
45c0bfb
Compare
ycombinator
force-pushed
the
del-xpack-monitoring
branch
from
45c0bfb
to
2469c46
Compare
|
jenkins, run tests please |
|
Travis CI is green and Jenkins CI failures look unrelated. Merging. |
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…ngs-archive * upstream/master: (274 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…nly-mod * upstream/master: (75 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Removing xpack.monitoring.* setting and corresponding code * Updating docs * Adding CHANGELOG entry * Removing ES calls to custom monitoring endpoints! * Removing xpack monitoring API params * Removing format from test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the
xpack.monitoring.*settings and associated code. This setting was deprecated in7.2.0in favor ofmonitoring.*settings (see #9260). Users will now have to use the newmonitoring.*settings instead.Why is it important?
The
xpack.monitoring.*settings routed Beats monitoring data from the Beat => ES production cluster (determined by the value ofxpack.monitoring.elasticsearch.hostsoroutput.elasticsearch.hosts) => ES monitoring cluster. This path of routing monitoring data is going away in 8.0.0.Instead, starting 8.0.0 Beats (and indeed all other Elastic Stack products) will be required to ship their monitoring data from Beat => ES monitoring cluster (determined by the value of
monitoring.elasticsearch.hosts).Checklist
I have made corresponding change to the default configuration filesxpack.monitoring.*settings were already removed from default configuration files when they were deprecated in 7.2.0.I have added tests that prove my fix is effective or that my feature worksTests already exist.CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues