Fix gob encoding of system/package struct data #18887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
The system/package dataset uses encoding/gob to encode and decode the Package struct data that it persists. The struct was updated to contain an error which is an interface type that's not serializable by default. I have made the field unexpected so that it is ignored by encoding/gob. Fixes elastic#18536
andrewkroh
force-pushed
the
bugfix/ab/system-package-gob-encoding
branch
from
a86f59c
to
8852d7c
Compare
andrewkroh
added
review
needs_backport
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
leehinman
approved these changes
Jun 3, 2020
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 8, 2020
The system/package dataset uses encoding/gob to encode and decode the Package struct data that it persists. The struct was updated to contain an error which is an interface type that's not serializable by default. I have made the field unexpected so that it is ignored by encoding/gob. Fixes elastic#18536 (cherry picked from commit cf7b643)
4 tasks
andrewkroh
added
v7.9.0
and removed
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 8, 2020
The system/package dataset uses encoding/gob to encode and decode the Package struct data that it persists. The struct was updated to contain an error which is an interface type that's not serializable by default. I have made the field unexpected so that it is ignored by encoding/gob. Fixes elastic#18536 (cherry picked from commit cf7b643)
4 tasks
andrewkroh
added a commit
that referenced
this pull request
Jun 8, 2020
The system/package dataset uses encoding/gob to encode and decode the Package struct data that it persists. The struct was updated to contain an error which is an interface type that's not serializable by default. I have made the field unexpected so that it is ignored by encoding/gob. Fixes #18536 (cherry picked from commit cf7b643)
andrewkroh
added a commit
that referenced
this pull request
Jun 9, 2020
The system/package dataset uses encoding/gob to encode and decode the Package struct data that it persists. The struct was updated to contain an error which is an interface type that's not serializable by default. I have made the field unexpected so that it is ignored by encoding/gob. Fixes #18536 (cherry picked from commit cf7b643)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
The system/package dataset uses encoding/gob to encode and decode the Package struct data that it persists. The struct was updated to contain an error which is an interface type that's not serializable by default. I have made the field unexpected so that it is ignored by encoding/gob. Fixes elastic#18536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The system/package dataset uses encoding/gob to encode and decode
the Package struct data that it persists. The struct was updated to contain
an error which is an interface type that's not serializable by default.
I have made the field unexpected so that it is ignored by encoding/gob.
Why is it important?
The Auditbeat system module was emitting errors at runtime.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues