Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Rename input.type logs to logfile #19360

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[Ingest Manager] Rename input.type logs to logfile #19360

merged 1 commit into from
Jun 24, 2020

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

Adds additional option for specifying intput.type: logfile
this should replace input.type: logs
dataset.type stays logs

Why is it important?

To avoid confusion between input.type and dataset.type as well as between various implementations of logs (file, syslog...)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #19318

@michalpristas michalpristas added review needs_backport PR is waiting to be backported to other branches. Team:Ingest Management Ingest Management:beta1 Group issues for ingest management beta1 labels Jun 24, 2020
@michalpristas michalpristas self-assigned this Jun 24, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020
@michalpristas michalpristas changed the title logs to logfile [Ingest Manager] Rename input.type logs to logfile Jun 24, 2020
ruflin
ruflin approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As soon as this landed in master / 7.x, can you create a follow up issue in the integrations repo to adjust it?

Will this change showup somewhere in a changelog?

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19360 opened]

  • Start Time: 2020-06-24T10:16:58.920+0000

  • Duration: 33 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 539
Skipped 127
Total 666

@michalpristas michalpristas merged commit ebe5373 into elastic:master Jun 24, 2020
@michalpristas michalpristas mentioned this pull request Jun 24, 2020
Merged
6 tasks
michalpristas added a commit to michalpristas/beats that referenced this pull request Jun 24, 2020
@michalpristas
[Ingest Manager] Rename input.type logs to logfile (elastic#19360)
bd97a80 
[Ingest Manager] Rename input.type logs to logfile (elastic#19360)
michalpristas added a commit that referenced this pull request Jun 25, 2020
@michalpristas
Cherry-pick #19360 to 7.x: Rename input.type logs to logfile (#19362)
919fc21 
* [Ingest Manager] Rename input.type logs to logfile (#19360)

[Ingest Manager] Rename input.type logs to logfile (#19360)

* missing changelog

* mod
This was referenced Jun 25, 2020
Merged
Closed
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@michalpristas @melchiormoulin
[Ingest Manager] Rename input.type logs to logfile (elastic#19360)
209f58d 
[Ingest Manager] Rename input.type logs to logfile (elastic#19360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@michalpristas michalpristas

Labels
Ingest Management:beta1 Group issues for ingest management beta1 needs_backport PR is waiting to be backported to other branches. review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Elastic Agent] Rename input.type: log to logfile
3 participants
@michalpristas @elasticmachine @ruflin