Build docker images based on Red Hat UBI #20576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
jsoriano
added
Team:Integrations
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
|
/packaging |
jsoriano
force-pushed
the
ubi-docker-images
branch
from
8d33902
to
6cf2143
Compare
|
/packaging |
jsoriano
force-pushed
the
ubi-docker-images
branch
from
46ebfa6
to
b7ef2b0
Compare
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
|
/packaging |
axw
approved these changes
Aug 18, 2020
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
andrewkroh
approved these changes
Aug 19, 2020
|
|
||
| var requiredPackages []string | ||
| for _, p := range platformPackages { | ||
| if _, enabled := devtools.Platforms.Get(p.platform); enabled { |
|
@blakerouse can you take a look? |
michalpristas
approved these changes
Aug 24, 2020
| if err != nil { | ||
| // specific missing fallback to generic | ||
| dockerfile = "Dockerfile.tmpl" | ||
| dockerfile := "Dockerfile.tmpl" |
15 tasks
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 24, 2020
Add an additional docker build that builds images based on Red Hat UBI, following Red Hat requirements for certified images. Additional checks have been added to packaging tests for labels and licenses. Additional changes done to support it also in Elastic Agent images: * Home directory is prepared in a different stage (elastic#20356). * Allow the docker image to be run with random user ids (elastic#18873). * Explicitly select a Dockerfile and entry point template. * Add NOTICE.txt file to all agent packages. * Actually run package tests after building packages, added flag to allow root user. * Improved checks on required packages, so they are not re-built if they already are. (cherry picked from commit e31794d)
jsoriano
added a commit
that referenced
this pull request
Aug 24, 2020
Add an additional docker build that builds images based on Red Hat UBI, following Red Hat requirements for certified images. Additional checks have been added to packaging tests for labels and licenses. Additional changes done to support it also in Elastic Agent images: * Home directory is prepared in a different stage (#20356). * Allow the docker image to be run with random user ids (#18873). * Explicitly select a Dockerfile and entry point template. * Add NOTICE.txt file to all agent packages. * Actually run package tests after building packages, added flag to allow root user. * Improved checks on required packages, so they are not re-built if they already are. (cherry picked from commit e31794d)
3 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Add an additional docker build that builds images based on Red Hat UBI, following Red Hat requirements for certified images. Additional checks have been added to packaging tests for labels and licenses. Additional changes done to support it also in Elastic Agent images: * Home directory is prepared in a different stage (elastic#20356). * Allow the docker image to be run with random user ids (elastic#18873). * Explicitly select a Dockerfile and entry point template. * Add NOTICE.txt file to all agent packages. * Actually run package tests after building packages, added flag to allow root user. * Improved checks on required packages, so they are not re-built if they already are.
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an additional docker build that builds images based on Red Hat UBI, following Red Hat requirements for certified images.
Additional checks have been added to packaging tests for labels and licenses.
Additional changes done to support it also in Elastic Agent images:
-oss,-ubi8...).NOTICE.txtfile to all agent packages.NOTE: Some of the changes for Elastic Agent could be actually moved to separate PRs, but they are quite intertwined and I would like to test them together. I decided to do them on this PR to don't have to conditionally disable package tests, and to be able to test everything together. But happy to move them to other PRs if preferred.
Why is it important?
To build images that can be certified for Red Hat OpenShift.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
/licensesPossibly to be done in a follow up PR
How to test this PR locally
Related issues