Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a fixed version of setuptools #21393

Merged
merged 1 commit into from Sep 30, 2020

Conversation

kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Sep 29, 2020

What does this PR do?

It fixed the version of setuptools to 40

Why is it important?

pytest-rerunfailures needs it and the installed version is 39.0.1

pytest-rerunfailures 9.0 requires setuptools>=40.0, but you'll have setuptools 39.0.1 which is incompatible.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #21375

@kuisathaverat kuisathaverat added bug automation ci Team:Automation Label for the Observability productivity team labels Sep 29, 2020
@kuisathaverat kuisathaverat requested review from jsoriano and a team September 29, 2020 15:59
@kuisathaverat kuisathaverat self-assigned this Sep 29, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 29, 2020
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, but maybe we should try with the version we are using in other places.

libbeat/scripts/Makefile Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21393 updated]

  • Start Time: 2020-09-30T07:33:41.682+0000

  • Duration: 94 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 16178
Skipped 1333
Total 17511

@kuisathaverat kuisathaverat merged commit 222b069 into elastic:master Sep 30, 2020
kuisathaverat added a commit to kuisathaverat/beats that referenced this pull request Sep 30, 2020
kuisathaverat added a commit to kuisathaverat/beats that referenced this pull request Sep 30, 2020
# Conflicts:
#	libbeat/tests/system/requirements.txt
kuisathaverat added a commit that referenced this pull request Sep 30, 2020
# Conflicts:
#	libbeat/tests/system/requirements.txt
v1v added a commit to v1v/beats that referenced this pull request Sep 30, 2020
…ci-build-label-support

* upstream/master:
  [JJBB] Set shallow cloning to 10 (elastic#21409)
  docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419)
  docs: Prepare Changelog for 7.9.2 (elastic#21229) (elastic#21403)
  fix: mark flaky tests (elastic#21300)
  fix: use a fixed version of setuptools (elastic#21393)
  Move Kubernetes events metricset to its own block in reference config (elastic#21407)
  [libbeat] Enable WriteAheadLimit in the disk queue (elastic#21391)
  docs: fix apt/yum formatting (elastic#21362)
  Fix shutdown tracking in s3 input (elastic#21380)
  [libbeat] Fix position writing in the disk queue
  Add UBI 8 image to the dependencies report (elastic#21374)
  Fix debug message to show actual SQS message ID (elastic#20614)
  [Elastic Agent] Rename *ConfigChange to PolicyChange (elastic#20779)
  [Elastic Agent] Add install/uninstall sub-command (elastic#21206)
  [Filebeat][httpjson] Make httpjson use cursor input when using date cursor (elastic#20751)
  feat: prepare release pipelines (elastic#21238)
  Add IP validation to Security module (elastic#21325)
v1v added a commit to v1v/beats that referenced this pull request Oct 2, 2020
* upstream/master: (27 commits)
  [Ingest Manager] Split index restrictions into type,dataset, namespace parts (elastic#21406)
  Update Filebeat module expected logs files (elastic#21454)
  Edit SQL module docs and fix broken doc structure (elastic#21233)
  [Ingest Manager] Send snapshot flag together with metadata (elastic#21285)
  Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)
  [JJBB] Use reference repo for fast checkouts (elastic#21410)
  Add initial skeleton of filestream input (elastic#21427)
  Initial spec file for apm-server (elastic#21225)
  [Ingest Manager] Upgrade Action: make source URI optional (elastic#21372)
  Add field limit check for AWS Cloudtrail flattened fields (elastic#21388)
  [Winlogbeat] Move winlogbeat javascript processor to libbeat (elastic#21402)
  ci: pipeline to generate the changelog (elastic#21426)
  [JJBB] Set shallow cloning to 10 (elastic#21409)
  docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419)
  docs: Prepare Changelog for 7.9.2 (elastic#21229) (elastic#21403)
  fix: mark flaky tests (elastic#21300)
  fix: use a fixed version of setuptools (elastic#21393)
  Move Kubernetes events metricset to its own block in reference config (elastic#21407)
  [libbeat] Enable WriteAheadLimit in the disk queue (elastic#21391)
  docs: fix apt/yum formatting (elastic#21362)
  ...
@kuisathaverat kuisathaverat deleted the fix_setuptools branch December 24, 2020 11:06
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
# Conflicts:
#	libbeat/tests/system/requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation bug ci Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required setuptools>=40.0 for running and tests/system/Testbeat.py is not up-to-date in 7.9
4 participants