Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookup.exec processor #2153

Merged
merged 2 commits into from Aug 3, 2016
Merged

Add lookup.exec processor #2153

merged 2 commits into from Aug 3, 2016

Conversation

urso
Copy link

@urso urso commented Aug 2, 2016

experimental lookup processor.

$ go test -cover ./...
?       github.com/elastic/beats/libbeat/processors/actions/lookup  [no test files]
ok      github.com/elastic/beats/libbeat/processors/actions/lookup/exec 0.179s  coverage: 76.1% of statements
ok      github.com/elastic/beats/libbeat/processors/actions/lookup/lutool   0.328s  coverage: 86.8% of statements

@urso urso added discuss Issue needs further discussion. review labels Aug 2, 2016
@tsg
Copy link
Contributor

tsg commented Aug 3, 2016

@urso LGTM, but there's a windows compilation error (see appveyor & travis).

@tsg
Copy link
Contributor

tsg commented Aug 3, 2016

Oops, looks like the compile error is fixed and I was looking at an old run. Waiting for green.

@tsg
Copy link
Contributor

tsg commented Aug 3, 2016

The appveyor is probably a flaky test (fixed in #2159). Merging as is.

@tsg tsg merged commit 22ba647 into elastic:x-exec-lookup Aug 3, 2016
@urso
Copy link
Author

urso commented Aug 3, 2016

yeah, apparently syscall.SysProcAttr differs between different platforms.

@urso urso deleted the feat/exec/lookup branch February 19, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants