New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logstash/node metricset work for Stack Monitoring without xpack.enabled flag #21545

Closed

sayden wants to merge 5 commits into elastic:feature-stack-monitoring-mb-ecs from sayden:feature/mb/logstash/node_xpack_flag

Contributor

sayden commented Oct 5, 2020

Ready to test

sayden added 4 commits

October 2, 2020 20:48


          Atomic commit

9d0f7a8


          Run make update

ebbbf85


          Fix typo

1c36cf5


          Atomic commit

aaf70cd

sayden added Metricbeat Feature:Stack Monitoring Team:Services labels

sayden self-assigned this

Collaborator

elasticmachine commented Oct 5, 2020

Pinging @elastic/stack-monitoring (Stack monitoring)

Collaborator

elasticmachine commented Oct 5, 2020

Pinging @elastic/integrations-services (Team:Services)

botelastic bot added needs_team and removed needs_team labels

Collaborator

elasticmachine commented Oct 5, 2020 •

edited by jenkins-beats-ci bot

Loading

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #21545 updated
Start Time: 2020-12-04T15:06:44.248+0000
Duration: 56 min 6 sec

Test stats 🧪

Test	Results
Failed	14
Passed	2699
Skipped	250
Total	2963

Test errors

Expand to view the tests failures

> Show only the first 10 test failures

`Build&Test / metricbeat-unitTest / TestEventMapping – stats`

Expand to view the error details

 Failed

Expand to view the stacktrace

     ptest.go:134: Testing ./_meta/test/metrics file
panic: assignment to entry in nil map
/var/lib/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.linux.amd64/src/testing/testing.go:999 +0x319
/var/lib/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.linux.amd64/src/testing/testing.go:1002 +0x402
/var/lib/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.linux.amd64/src/runtime/panic.go:969 +0x166
/var/lib/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/libbeat/common/mapstr.go:467 +0x1ce
/var/lib/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/libbeat/common/mapstr.go:194 +0x51
/var/lib/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/metricbeat/module/kibana/stats/data.go:151 +0x2ee
/var/lib/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/metricbeat/module/kibana/stats/data_test.go:42 +0x1ad
/var/lib/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.linux.amd64/src/testing/testing.go:1050 +0xdc
/var/lib/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.linux.amd64/src/testing/testing.go:1095 +0x28b

`Build&Test / metricbeat-unitTest / [build failed] – node`

Expand to view the error details

 Failed

Expand to view the stacktrace

 module/logstash/node/data_test.go:43:28: cannot use reporter (type *"github.com/elastic/beats/v7/metricbeat/mb/testing".CapturingReporterV2) as type mb.Event in argument to commonFieldsMapping
module/logstash/node/data_test.go:43:28: cannot use input (type []byte) as type common.MapStr in argument to commonFieldsMapping

`Build&Test / metricbeat-windows-windows-2019 / TestEventMapping – stats`

Expand to view the error details

 Failed

Expand to view the stacktrace

     ptest.go:134: Testing ./_meta/test/metrics file
panic: assignment to entry in nil map
C:/Users/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.windows.amd64/src/testing/testing.go:999 +0x320
C:/Users/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.windows.amd64/src/testing/testing.go:1002 +0x409
C:/Users/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.windows.amd64/src/runtime/panic.go:969 +0x174
C:/Users/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/libbeat/common/mapstr.go:467 +0x1d5
C:/Users/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/libbeat/common/mapstr.go:194 +0x58
C:/Users/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/metricbeat/module/kibana/stats/data.go:151 +0x2f5
C:/Users/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats/metricbeat/module/kibana/stats/data_test.go:42 +0x1b4
C:/Users/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.windows.amd64/src/testing/testing.go:1050 +0xe3
C:/Users/jenkins/workspace/Beats_beats_PR-21545/.gvm/versions/go1.14.12.windows.amd64/src/testing/testing.go:1095 +0x292

`Build&Test / metricbeat-windows-windows-2019 / [build failed] – node`

Expand to view the error details

 Failed

Expand to view the stacktrace

 module\logstash\node\data_test.go:43:28: cannot use reporter (type *"github.com/elastic/beats/v7/metricbeat/mb/testing".CapturingReporterV2) as type mb.Event in argument to commonFieldsMapping
module\logstash\node\data_test.go:43:28: cannot use input (type []byte) as type common.MapStr in argument to commonFieldsMapping

`Build&Test / metricbeat-goIntegTest / TestXPackEnabled – kibana`

Expand to view the error details

 Failed

Expand to view the stacktrace

 panic: assignment to entry in nil map
/usr/local/go/src/testing/testing.go:999 +0x319
/usr/local/go/src/testing/testing.go:1002 +0x402
/usr/local/go/src/runtime/panic.go:969 +0x166
/go/src/github.com/elastic/beats/libbeat/common/mapstr.go:467 +0x1ce
/go/src/github.com/elastic/beats/libbeat/common/mapstr.go:194 +0x51
/go/src/github.com/elastic/beats/metricbeat/module/kibana/stats/data.go:151 +0x28e
/go/src/github.com/elastic/beats/metricbeat/module/kibana/stats/stats.go:168 +0x249
/go/src/github.com/elastic/beats/metricbeat/module/kibana/stats/stats.go:88 +0x86
/go/src/github.com/elastic/beats/metricbeat/mb/testing/modules.go:262 +0x60
/go/src/github.com/elastic/beats/metricbeat/module/kibana/kibana_integration_test.go:48 +0x40a
/usr/local/go/src/testing/testing.go:1050 +0xdc
/usr/local/go/src/testing/testing.go:1095 +0x28b

`Build&Test / metricbeat-goIntegTest / TestFetch – stats`

Expand to view the error details

 Failed

Expand to view the stacktrace

 Found orphan containers (metricbeat_8_0_0_270915dddd-snapshot_kafka_1, metricbeat_8_0_0_270915dddd-snapshot_http_1, metricbeat_8_0_0_270915dddd-snapshot_haproxy_1, metricbeat_8_0_0_270915dddd-snapshot_golang_1, metricbeat_8_0_0_270915dddd-snapshot_etcd_1, metricbeat_8_0_0_270915dddd-snapshot_envoyproxy_1) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
Creating metricbeat_8_0_0_270915dddd-snapshot_elasticsearch_1 ... 
Creating metricbeat_8_0_0_270915dddd-snapshot_elasticsearch_1 ... done
Creating metricbeat_8_0_0_270915dddd-snapshot_kibana_1        ... 
Creating metricbeat_8_0_0_270915dddd-snapshot_kibana_1        ... done
panic: assignment to entry in nil map
/usr/local/go/src/testing/testing.go:999 +0x319
/usr/local/go/src/testing/testing.go:1002 +0x402
/usr/local/go/src/runtime/panic.go:969 +0x166
/go/src/github.com/elastic/beats/libbeat/common/mapstr.go:467 +0x1ce
/go/src/github.com/elastic/beats/libbeat/common/mapstr.go:194 +0x51
/go/src/github.com/elastic/beats/metricbeat/module/kibana/stats/data.go:151 +0x2ee
/go/src/github.com/elastic/beats/metricbeat/module/kibana/stats/stats.go:168 +0x2a9
/go/src/github.com/elastic/beats/metricbeat/module/kibana/stats/stats.go:88 +0xa6
/go/src/github.com/elastic/beats/metricbeat/mb/testing/modules.go:262 +0x60
/go/src/github.com/elastic/beats/metricbeat/module/kibana/stats/stats_integration_test.go:54 +0x423
/usr/local/go/src/testing/testing.go:1050 +0xdc
/usr/local/go/src/testing/testing.go:1095 +0x28b

`Build&Test / metricbeat-goIntegTest / TestFetch – logstash`

Expand to view the error details

 Failed

Expand to view the stacktrace

 Found orphan containers (metricbeat_8_0_0_270915dddd-snapshot_kafka_1, metricbeat_8_0_0_270915dddd-snapshot_http_1, metricbeat_8_0_0_270915dddd-snapshot_haproxy_1) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
Building logstash
Step 1/6 : ARG LOGSTASH_VERSION
Step 2/6 : FROM docker.elastic.co/logstash/logstash:${LOGSTASH_VERSION}
7.10.0: Pulling from logstash/logstash
Digest: sha256:db7e1d25f78d0a67da17d84e69147df7b937b534b8bddee14637ad8407aface8
Status: Downloaded newer image for docker.elastic.co/logstash/logstash:7.10.0
 ---> bc71baf6997e
Step 3/6 : COPY healthcheck.sh /
 ---> 4cdaceaef6f9
Step 4/6 : COPY pipeline/logstash.conf /usr/share/logstash/pipeline/logstash.conf
 ---> 4e5879245e4a
Step 5/6 : ENV XPACK_MONITORING_ENABLED=FALSE
 ---> Running in 545e3fb04906
Removing intermediate container 545e3fb04906
 ---> 980ad81aa2de
Step 6/6 : HEALTHCHECK --interval=1s --retries=300 CMD sh /healthcheck.sh
 ---> Running in 5be1d5670d40
Removing intermediate container 5be1d5670d40
 ---> 26dac75feef7

Successfully built 26dac75feef7
Successfully tagged docker.elastic.co/integrations-ci/beats-logstash:7.10.0-1
Image for service logstash was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Creating metricbeat_8_0_0_270915dddd-snapshot_elasticsearch_1 ... 
Creating metricbeat_8_0_0_270915dddd-snapshot_elasticsearch_1 ... done
Creating metricbeat_8_0_0_270915dddd-snapshot_logstash_1      ... 
Creating metricbeat_8_0_0_270915dddd-snapshot_logstash_1      ... done

`Build&Test / metricbeat-goIntegTest / TestFetch/node – logstash`

Expand to view the error details

 Failed

Expand to view the stacktrace

 panic: assignment to entry in nil map
/usr/local/go/src/testing/testing.go:999 +0x319
/usr/local/go/src/testing/testing.go:1002 +0x402
/usr/local/go/src/runtime/panic.go:969 +0x166
/go/src/github.com/elastic/beats/libbeat/common/mapstr.go:467 +0x1ce
/go/src/github.com/elastic/beats/libbeat/common/mapstr.go:194 +0x51
/go/src/github.com/elastic/beats/metricbeat/module/logstash/node/data.go:123 +0x4ff
/go/src/github.com/elastic/beats/metricbeat/module/logstash/node/node.go:82 +0x104
/go/src/github.com/elastic/beats/metricbeat/mb/testing/modules.go:262 +0x60
/go/src/github.com/elastic/beats/metricbeat/module/logstash/logstash_integration_test.go:49 +0x2bf
/usr/local/go/src/testing/testing.go:1050 +0xdc
/usr/local/go/src/testing/testing.go:1095 +0x28b

`Build&Test / metricbeat-pythonIntegTest / test_migration – metricbeat.tests.system.test_base.Test`

Expand to view the error details

 AssertionError: assert 1 == 0

Expand to view the stacktrace

 self = <test_base.Test testMethod=test_migration>

    @unittest.skipUnless(INTEGRATION_TESTS, "integration test")
    def test_migration(self):
        """
        Test that the template loads when migration is enabled
        """
    
        es = Elasticsearch([self.get_elasticsearch_url()])
        self.render_config_template(
            modules=[{
                "name": "apache",
                "metricsets": ["status"],
                "hosts": ["localhost"],
            }],
            elasticsearch={"host": self.get_elasticsearch_url()},
        )
        exit_code = self.run_beat(extra_args=["setup", "--template",
                                              "-E", "setup.template.overwrite=true", "-E", "migration.6_to_7.enabled=true"])
    
>       assert exit_code == 0
E       AssertionError: assert 1 == 0

tests/system/test_base.py:100: AssertionError

`Build&Test / metricbeat-pythonIntegTest / test_template – metricbeat.tests.system.test_base.Test`

Expand to view the error details

 AssertionError: assert 1 == 0

Expand to view the stacktrace

 self = <test_base.Test testMethod=test_template>

    @unittest.skipUnless(INTEGRATION_TESTS, "integration test")
    def test_template(self):
        """
        Test that the template can be loaded with `setup --template`
        """
        es = Elasticsearch([self.get_elasticsearch_url()])
        self.render_config_template(
            modules=[{
                "name": "apache",
                "metricsets": ["status"],
                "hosts": ["localhost"],
            }],
            elasticsearch={"host": self.get_elasticsearch_url()},
        )
        exit_code = self.run_beat(extra_args=["setup", "--template", "-E", "setup.template.overwrite=true"])
    
>       assert exit_code == 0
E       AssertionError: assert 1 == 0

tests/system/test_base.py:55: AssertionError

Steps errors

Expand to view the steps failures

`metricbeat-Lint - make -C metricbeat check;

make -C metricbeat update;
make check-no-changes;
`

Took 3 min 32 sec . View more details on here
Description: make -C metricbeat check;make -C metricbeat update;make check-no-changes;

`metricbeat-unitTest - mage build unitTest`

Took 3 min 4 sec . View more details on here
Description: mage build unitTest

`metricbeat-goIntegTest - mage goIntegTest`

Took 24 min 37 sec . View more details on here
Description: mage goIntegTest

`metricbeat-pythonIntegTest - mage pythonIntegTest`

Took 32 min 35 sec . View more details on here
Description: mage pythonIntegTest

`metricbeat-windows-windows-2019 - mage build unitTest`

Took 4 min 39 sec . View more details on here
Description: mage build unitTest

`Terraform Apply on x-pack/metricbeat/module/aws`

Took 0 min 4 sec . View more details on here

`Terraform Apply on x-pack/metricbeat/module/aws`

Took 0 min 3 sec . View more details on here

`x-pack/metricbeat-build - mage build test`

Took 29 min 4 sec . View more details on here
Description: mage build test

`Error signal`

Took 0 min 0 sec . View more details on here
Description: Error 'hudson.AbortException: script returned exit code 2'

Log output

Expand to view the last 100 lines of log output

[2020-12-04T16:02:06.669Z] + echo 'Found Go. Checking version..'
[2020-12-04T16:02:06.669Z] Found Go. Checking version..
[2020-12-04T16:02:06.669Z] ++ go version
[2020-12-04T16:02:06.669Z] ++ awk '{print $3}'
[2020-12-04T16:02:06.669Z] ++ sed s/go//
[2020-12-04T16:02:06.669Z] + FOUND_GO_VERSION=1.14.12
[2020-12-04T16:02:06.669Z] + '[' 1.14.12 == 1.14.12 ']'
[2020-12-04T16:02:06.669Z] + echo 'Versions match. No need to install Go. Exiting.'
[2020-12-04T16:02:06.669Z] Versions match. No need to install Go. Exiting.
[2020-12-04T16:02:06.669Z] + exit 0
[2020-12-04T16:02:06.669Z] + .ci/scripts/install-docker-compose.sh
[2020-12-04T16:02:06.669Z] + MSG='environment variable missing: DOCKER_COMPOSE_VERSION.'
[2020-12-04T16:02:06.669Z] + DOCKER_COMPOSE_VERSION=1.21.0
[2020-12-04T16:02:06.669Z] + HOME=/var/lib/jenkins/workspace/Beats_beats_PR-21545
[2020-12-04T16:02:06.669Z] + command -v docker-compose
[2020-12-04T16:02:06.669Z] /usr/local/bin/docker-compose
[2020-12-04T16:02:06.669Z] + echo 'Found docker-compose. Checking version..'
[2020-12-04T16:02:06.669Z] Found docker-compose. Checking version..
[2020-12-04T16:02:06.669Z] ++ docker-compose --version
[2020-12-04T16:02:06.669Z] ++ awk '{print $3}'
[2020-12-04T16:02:06.669Z] ++ sed s/,//
[2020-12-04T16:02:06.929Z] + FOUND_DOCKER_COMPOSE_VERSION=1.23.2
[2020-12-04T16:02:06.929Z] + '[' 1.23.2 == 1.21.0 ']'
[2020-12-04T16:02:06.929Z] + echo 'UNMET DEP: Installing docker-compose'
[2020-12-04T16:02:06.929Z] UNMET DEP: Installing docker-compose
[2020-12-04T16:02:06.929Z] + DC_CMD=/var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/docker-compose
[2020-12-04T16:02:06.929Z] + mkdir -p /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin
[2020-12-04T16:02:06.929Z] ++ uname -s
[2020-12-04T16:02:06.929Z] ++ uname -m
[2020-12-04T16:02:06.929Z] + curl -sSLo /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/docker-compose https://github.com/docker/compose/releases/download/1.21.0/docker-compose-Linux-x86_64
[2020-12-04T16:02:07.867Z] + chmod +x /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/docker-compose
[2020-12-04T16:02:07.867Z] + .ci/scripts/install-terraform.sh
[2020-12-04T16:02:07.867Z] + MSG='environment variable missing.'
[2020-12-04T16:02:07.867Z] + TERRAFORM_VERSION=0.12.24
[2020-12-04T16:02:07.867Z] + HOME=/var/lib/jenkins/workspace/Beats_beats_PR-21545
[2020-12-04T16:02:07.867Z] + TERRAFORM_CMD=/var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/terraform
[2020-12-04T16:02:07.867Z] ++ uname -s
[2020-12-04T16:02:07.867Z] ++ tr '[:upper:]' '[:lower:]'
[2020-12-04T16:02:07.867Z] + OS=linux
[2020-12-04T16:02:07.867Z] + command -v terraform
[2020-12-04T16:02:07.867Z] + echo 'UNMET DEP: Installing Terraform'
[2020-12-04T16:02:07.867Z] UNMET DEP: Installing Terraform
[2020-12-04T16:02:07.867Z] + mkdir -p /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin
[2020-12-04T16:02:07.867Z] + curl -sSLo - https://releases.hashicorp.com/terraform/0.12.24/terraform_0.12.24_linux_amd64.zip
[2020-12-04T16:02:08.436Z] ++ dirname /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/terraform
[2020-12-04T16:02:08.436Z] + unzip -o /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/terraform.zip -d /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin
[2020-12-04T16:02:08.436Z] Archive:  /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/terraform.zip
[2020-12-04T16:02:09.005Z]   inflating: /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/terraform  
[2020-12-04T16:02:09.005Z] + rm /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/terraform.zip
[2020-12-04T16:02:09.005Z] + chmod +x /var/lib/jenkins/workspace/Beats_beats_PR-21545/bin/terraform
[2020-12-04T16:02:09.005Z] + make mage
[2020-12-04T16:02:09.005Z] Installing mage v1.10.0.
[2020-12-04T16:02:09.574Z] go: downloading github.com/magefile/mage v1.10.0
[2020-12-04T16:02:10.953Z] /var/lib/jenkins/workspace/Beats_beats_PR-21545/.magefile cleaned
[2020-12-04T16:02:11.252Z] + git config --get user.email
[2020-12-04T16:02:11.252Z] + [ -z  ]
[2020-12-04T16:02:11.252Z] + git config --global user.email beatsmachine@users.noreply.github.com
[2020-12-04T16:02:11.252Z] + git config --global user.name beatsmachine
[2020-12-04T16:02:11.541Z] + go mod download
[2020-12-04T16:02:32.726Z] + .ci/scripts/terraform-cleanup.sh x-pack/metricbeat
[2020-12-04T16:02:32.726Z] + DIRECTORY=x-pack/metricbeat
[2020-12-04T16:02:32.726Z] + FAILED=0
[2020-12-04T16:02:32.726Z] ++ find x-pack/metricbeat -name terraform.tfstate
[2020-12-04T16:02:32.726Z] + exit 0
[2020-12-04T16:02:33.046Z] Client: Docker Engine - Community
[2020-12-04T16:02:33.046Z]  Version:           19.03.14
[2020-12-04T16:02:33.046Z]  API version:       1.40
[2020-12-04T16:02:33.046Z]  Go version:        go1.13.15
[2020-12-04T16:02:33.046Z]  Git commit:        5eb3275d40
[2020-12-04T16:02:33.046Z]  Built:             Tue Dec  1 19:20:17 2020
[2020-12-04T16:02:33.046Z]  OS/Arch:           linux/amd64
[2020-12-04T16:02:33.046Z]  Experimental:      false
[2020-12-04T16:02:33.046Z] 
[2020-12-04T16:02:33.046Z] Server: Docker Engine - Community
[2020-12-04T16:02:33.046Z]  Engine:
[2020-12-04T16:02:33.046Z]   Version:          19.03.14
[2020-12-04T16:02:33.046Z]   API version:      1.40 (minimum version 1.12)
[2020-12-04T16:02:33.046Z]   Go version:       go1.13.15
[2020-12-04T16:02:33.046Z]   Git commit:       5eb3275d40
[2020-12-04T16:02:33.046Z]   Built:            Tue Dec  1 19:18:45 2020
[2020-12-04T16:02:33.046Z]   OS/Arch:          linux/amd64
[2020-12-04T16:02:33.046Z]   Experimental:     false
[2020-12-04T16:02:33.047Z]  containerd:
[2020-12-04T16:02:33.047Z]   Version:          1.3.9
[2020-12-04T16:02:33.047Z]   GitCommit:        ea765aba0d05254012b0b9e595e995c09186427f
[2020-12-04T16:02:33.047Z]  runc:
[2020-12-04T16:02:33.047Z]   Version:          1.0.0-rc10
[2020-12-04T16:02:33.047Z]   GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
[2020-12-04T16:02:33.047Z]  docker-init:
[2020-12-04T16:02:33.047Z]   Version:          0.18.0
[2020-12-04T16:02:33.047Z]   GitCommit:        fec3683
[2020-12-04T16:02:49.541Z] Failed in branch x-pack/metricbeat-build
[2020-12-04T16:02:49.618Z] Stage "Packaging" skipped due to earlier failure(s)
[2020-12-04T16:02:49.666Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21545/src/github.com/elastic/beats
[2020-12-04T16:02:49.953Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-21545
[2020-12-04T16:02:50.032Z] [INFO] getVaultSecret: Getting secrets
[2020-12-04T16:02:50.089Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-12-04T16:02:50.719Z] + chmod 755 generate-build-data.sh
[2020-12-04T16:02:50.719Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21545/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21545/runs/2 FAILURE 3366212
[2020-12-04T16:02:50.719Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21545/runs/2/steps/?limit=10000 -o steps-info.json

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	14
Passed	2699
Skipped	250
Total	2963

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

Name: Build&Test / metricbeat-unitTest / TestEventMapping – stats
Name: Build&Test / metricbeat-unitTest / [build failed] – node
Name: Build&Test / metricbeat-windows-windows-2019 / TestEventMapping – stats
Name: Build&Test / metricbeat-windows-windows-2019 / [build failed] – node
Name: Build&Test / metricbeat-goIntegTest / TestXPackEnabled – kibana
Name: Build&Test / metricbeat-goIntegTest / TestFetch – stats
Name: Build&Test / metricbeat-goIntegTest / TestFetch – logstash
Name: Build&Test / metricbeat-goIntegTest / TestFetch/node – logstash
Name: Build&Test / metricbeat-pythonIntegTest / test_migration – metricbeat.tests.system.test_base.Test
Name: Build&Test / metricbeat-pythonIntegTest / test_template – metricbeat.tests.system.test_base.Test
Name: Build&Test / metricbeat-pythonIntegTest / test_xpack – metricbeat.module.kibana.test_kibana.Test
Name: Build&Test / metricbeat-pythonIntegTest / test_node – metricbeat.module.logstash.test_logstash.Test
Name: Build&Test / x-pack/metricbeat-build / test_migration – x-pack.metricbeat.tests.system.test_xpack_base.Test
Name: Build&Test / x-pack/metricbeat-build / test_template – x-pack.metricbeat.tests.system.test_xpack_base.Test

Contributor

chrisronline commented Oct 23, 2020

This PR contains the kibana changes as well, and I'm still seeing #21496 (comment)

Contributor Author

sayden commented Nov 3, 2020

Sorry. I'll leave this one until we have finished #21546 until I understand few of the difference between this metricset and node_stats because I don't understand if they are overlapping fields or what. There's also a logstash and logstash_stats in the monitoring mapping that I need to ask to @ycombinator

Contributor

ycombinator commented Nov 9, 2020

There's also a logstash and logstash_stats in the monitoring mapping that I need to ask to @ycombinator

Sure, what's your question?


          Merge branch 'feature-stack-monitoring-mb-ecs' into feature/mb/logsta…

270915d

…sh/node_xpack_flag

# Conflicts:
#	metricbeat/module/kibana/stats/stats.go
#	metricbeat/module/logstash/node/data_xpack.go

Contributor

ycombinator commented Dec 15, 2020 •

edited

Loading

@sayden Looks like the changes in #21546 cover both the logstash/node and logstash/node_stats metricsets. Do we even need this PR here any more?

Contributor Author

sayden commented Dec 15, 2020

This PR is finally merged into #19747

sayden closed this

Contributor

ycombinator commented Dec 15, 2020 •

edited

Loading

This PR is finally merged into #19747

I think you mean #21546? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment