Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Re-add Stack Monitoring section in elasticsearch module #23286

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 24, 2020

What does this PR do?

This PR re-adds the "Usage for Stack Monitoring" section in the Metricbeat Elasticsearch module documentation (https://www.elastic.co/guide/en/beats/metricbeat/7.9/metricbeat-module-elasticsearch.html), which was removed in 7.10 and later versions by #18547

Why is it important?

This "Usage for Stack Monitoring" section appears in the Beat, Kibana, and Logstash module docs and gives us something to link to from the stack monitoring setup docs.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    ~~- [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 24, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 24, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23286 updated

    • Start Time: 2021-01-18T20:09:20.455+0000
  • Duration: 22 min 37 sec

  • Commit: b7375c2

❕ Flaky test report

No test was executed to be analysed.

@lcawl lcawl added Feature:Stack Monitoring Team:Docs Label for the Observability docs team Team:Integrations Label for the Integrations team labels Dec 25, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 25, 2020
@lcawl lcawl force-pushed the stack-monitoring-elasticsearch branch from 18cdf49 to 360eb85 Compare December 29, 2020 17:57
@lcawl lcawl marked this pull request as ready for review December 29, 2020 18:37
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a rebase. Sorry this dropped off my radar over the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Stack Monitoring Team:Docs Label for the Observability docs team Team:Integrations Label for the Integrations team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants