-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[elastic-agent] fix: cpu cgroup values #23714
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did not test it locally but definitively looks like a typo.
# When running under Docker, we must ensure libbeat monitoring pulls cgroup | ||
# metrics from /sys/fs/cgroup/<subsystem>/, ignoring any paths found in | ||
# /proc/self/cgroup. | ||
ENV LIBBEAT_MONITORING_CGROUPS_HIERARCHY_OVERRIDE=/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same fix as in #22879
Pinging @elastic/agent (Team:Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Failing E2E tests are unrelated. |
* fix: cpu cgroup values * fix:path for cgroup collection in docker
What does this PR do?
Minor fix for collecting
cgroup
based metrics.follow up of #22793
Why is it important?
cgroups metrics are not reported due to a typo
How to test
DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 TYPES=docker mage package
--cpu-period=100000 --cpu-quota=50000
cgroup
values are set