Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ec2 metricset fields.yml and add integration test #23726

Merged
merged 12 commits into from
Feb 16, 2021
Merged

Fix ec2 metricset fields.yml and add integration test #23726

merged 12 commits into from
Feb 16, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jan 27, 2021

What does this PR do?

This PR is to fix ec2 metricset fields.yml for diskio metrics.

This PR also fix the ec2 integration test(#20951) in this PR and add field check to avoid this problem from happening again.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 27, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jan 27, 2021
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Jan 27, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 27, 2021
@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review February 4, 2021 21:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Platforms)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23726 updated

  • Start Time: 2021-02-16T14:16:51.439+0000

  • Duration: 47 min 30 sec

  • Commit: d629628

Test stats 🧪

Test Results
Failed 0
Passed 9231
Skipped 2247
Total 11478

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9231
Skipped 2247
Total 11478

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

x-pack/metricbeat/module/aws/terraform.tf Show resolved Hide resolved
@kaiyan-sheng kaiyan-sheng changed the title Fix ec2 metricset fields.yml Fix ec2 metricset fields.yml and add integration test Feb 5, 2021
@kaiyan-sheng kaiyan-sheng added the needs_backport PR is waiting to be backported to other branches. label Feb 8, 2021
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but failure in docs build may be related.

@kaiyan-sheng
Copy link
Contributor Author

LGTM, but failure in docs build may be related.

I can't open the link for CI docs failure for some reason hmm I will rebase this PR and check for the error if it comes up again! Thanks!

@jsoriano
Copy link
Member

Ok, false alarm, it passed now 🙂

x-pack/metricbeat/module/aws/terraform.tf Outdated Show resolved Hide resolved
kaiyan-sheng and others added 2 commits February 16, 2021 07:13
@kaiyan-sheng kaiyan-sheng added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 16, 2021
kaiyan-sheng added a commit that referenced this pull request Feb 17, 2021
v1v added a commit to v1v/beats that referenced this pull request Feb 17, 2021
…-arm

* upstream/master:
  [CI] install docker-compose with retry (elastic#24069)
  Add nodes to filebeat-kubernetes.yaml ClusterRole - fixes elastic#24051 (elastic#24052)
  updating manifest files for filebeat threatintel module (elastic#24074)
  Add Zeek Signatures (elastic#23772)
  Update Beats to ECS 1.8.0 (elastic#23465)
  Support running Docker logging plugin on ARM64 (elastic#24034)
  Fix ec2 metricset fields.yml and add integration test (elastic#23726)
  Only build targz and zip versions of Beats if PACKAGES is set in agent (elastic#24060)
  [Filebeat] Add field definitions for known Netflow/IPFIX vendor fields (elastic#23773)
  [Elastic Agent] Enroll with Fleet Server (elastic#23865)
  [Filebeat] Convert logstash logEvent.action objects to strings (elastic#23944)
  [Ingest Management] Fix reloading of log level for services (elastic#24055)
  Add Agent standalone k8s manifest (elastic#23679)
v1v added a commit to v1v/beats that referenced this pull request Feb 17, 2021
…dows-7

* upstream/master: (332 commits)
  Use ECS v1.8.0 (elastic#24086)
  Add support for postgresql csv logs (elastic#23334)
  [Heartbeat] Refactor config system (elastic#23467)
  [CI] install docker-compose with retry (elastic#24069)
  Add nodes to filebeat-kubernetes.yaml ClusterRole - fixes elastic#24051 (elastic#24052)
  updating manifest files for filebeat threatintel module (elastic#24074)
  Add Zeek Signatures (elastic#23772)
  Update Beats to ECS 1.8.0 (elastic#23465)
  Support running Docker logging plugin on ARM64 (elastic#24034)
  Fix ec2 metricset fields.yml and add integration test (elastic#23726)
  Only build targz and zip versions of Beats if PACKAGES is set in agent (elastic#24060)
  [Filebeat] Add field definitions for known Netflow/IPFIX vendor fields (elastic#23773)
  [Elastic Agent] Enroll with Fleet Server (elastic#23865)
  [Filebeat] Convert logstash logEvent.action objects to strings (elastic#23944)
  [Ingest Management] Fix reloading of log level for services (elastic#24055)
  Add Agent standalone k8s manifest (elastic#23679)
  [Metricbeat][Kubernetes] Extend state_node with more conditions (elastic#23905)
  [CI] googleStorageUploadExt step (elastic#24048)
  Check fields are documented for aws metricsets (elastic#23887)
  Update go-concert to 0.1.0 (elastic#23770)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platforms Label for the Integrations - Platforms team v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants