[Filebeat] rfc6587 framing for fortinet firewall #23837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
- use rfc6587 framing when transferring fortinet firewall logs via syslog over TCP - use rfc6587 framing when transferring fortinet clientendpoint logs via syslog over TCP
leehinman
force-pushed
the
fortinet_octet_framing
branch
from
dca2fe4
to
5424334
Compare
leehinman
added
bug
Filebeat
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
3 tasks
leehinman
added
v7.12.0
and removed
needs_backport
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Feb 9, 2021
- use rfc6587 framing when transferring fortinet firewall logs via syslog over TCP - use rfc6587 framing when transferring fortinet clientendpoint logs via syslog over TCP (cherry picked from commit ed01b8f)
leehinman
added a commit
that referenced
this pull request
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes fortinet firewall & clientendpoint filesets to use rfc6587
framing when transferring logs via syslog over TCP
Why is it important?
This is necessary to support syslog messages inside TLS and over TCP
if octet counting is used.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentationCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Use pysyslogclient or other syslog client that can send using octet counting.