Cherry-pick #23770 to 7.x: Update go-concert to 0.1.0 #24050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
[zube]: In Review
backport
Team:Services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 46507 |
| Skipped | 4841 |
| Total | 51348 |
urso
commented
Feb 16, 2021
| l.Listener.Close() | ||
| }() | ||
|
|
||
| l.log.Info("Started listening for " + l.family.String() + " connection") |
There was a problem hiding this comment.
This code-block should not have existed in 7.x. Maybe some older backport that didn't go well.
Removing this block fixes:
- reduce chance for leaking resources due to an existing context being overwritten
- remove duplicate log message.
added 2 commits
February 17, 2021 14:11
(cherry picked from commit 342a845)
urso
force-pushed
the
backport_23770_7.x
branch
from
6e9dfc2
to
3b05dd2
Compare
kvch
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23770 to 7.x branch. Original message:
What does this PR do?
Update go-concert to version 0.1.0 and update some code in Beats.
Why is it important?
Uhm... UPDATES \o/
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.