Fix detect_sequence_reset flag in netflow module #24270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was not passed to the input unless set to true, which is the default. It was impossible to turn it off. Fixes elastic#24268
botelastic
bot
added
the
needs_team
adriansr
added
bug
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
|
/test |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
approved these changes
Mar 8, 2021
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 10, 2021
This flag was not passed to the input unless set to true, which is the default. It was impossible to turn it off. Fixes elastic#24268 (cherry picked from commit 22e20a1)
1 task
adriansr
added
v7.13.0
and removed
needs_backport
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 10, 2021
This flag was not passed to the input unless set to true, which is the default. It was impossible to turn it off. Fixes elastic#24268 (cherry picked from commit 22e20a1)
1 task
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 5375 |
| Skipped | 738 |
| Total | 6113 |
adriansr
added a commit
that referenced
this pull request
Mar 22, 2021
adriansr
added a commit
that referenced
this pull request
Mar 22, 2021
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#24459) This flag was not passed to the input unless set to true, which is the default. It was impossible to turn it off. Fixes elastic#24268 (cherry picked from commit 73b1fc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was not passed to the input unless set to true, which is the
default. It was impossible to turn it off.
What does this PR do?
Fixes the netflow module so that it passes the value in
var.detect_sequence_resetto the netflow input.Why is it important?
It was impossible to override the default for detect_sequence_reset (true).
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues