Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable packaging-arm in elastic-agent #26240

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Disable packaging-arm in elastic-agent #26240

merged 2 commits into from
Jun 14, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

What does this PR do?

This PR is to disable arm packaging in elastic-agent.

Why is it important?

Skipping this so mage package can pass in CI.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 10, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 10, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 10, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26240 updated

  • Start Time: 2021-06-10T17:23:06.018+0000

  • Duration: 91 min 45 sec

  • Commit: 44a1ce3

Test stats 🧪

Test Results
Failed 0
Passed 6908
Skipped 16
Total 6924

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6908
Skipped 16
Total 6924

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 10, 2021 17:22
@botelastic botelastic bot added Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 10, 2021
@kaiyan-sheng
Copy link
Contributor Author

@blakerouse @urso WDYT about disabling ARM packaging for elastic-agent for now?

@urso
Copy link

urso commented Jun 14, 2021

We do provide ARM packages for download. The build issue MUST be fixed properly. I'm not too keen to disable building, but if we can't fix it ASAP we might want to disable the ARM packaging job for PRs only. Master and 7.x should still fail on it.

@v1v
Copy link
Member

v1v commented Jun 14, 2021

but if we can't fix it ASAP we might want to disable the ARM packaging job for PRs only. Master and 7.x should still fail on it.

Then, it requires further changes in the CI to support only branches and tags.

  1. packaging-arm:
    packaging-arm: "mage package"
    e2e:
    enabled: false
    platforms: ## override default label in this specific stage.
    - "arm"
    stage: packaging
    should be something like:
    packaging-arm:
        packaging-arm: "mage package"
        e2e:
            enabled: false
        platforms:             ## override default label in this specific stage.
          - "arm"
        stage: packaging
        when:
            branches: true     ## for all the branches
            tags: true         ## for all the tags
  1. beats/.ci/packaging.groovy

    Lines 390 to 401 in 2ebf83e

    def release(){
    withBeatsEnv(){
    withEnv([
    "DEV=true"
    ]) {
    dir("${env.BEATS_FOLDER}") {
    sh(label: "Release ${env.BEATS_FOLDER} ${env.PLATFORMS}", script: 'mage package')
    }
    }
    publishPackages("${env.BEATS_FOLDER}")
    }
    }

    should be changed to filter (BEATS_FOLDER == 'x-pack/elastic-agent' && ! isPR()) in order to do nothing.

@ph
Copy link
Contributor

ph commented Jun 14, 2021

Lets merge this so the build is green will followup with that in priority.

@urso
Copy link

urso commented Jun 14, 2021

PRs are blocked for a few days. Let's make progress here. The ARM packaging should be restored ASAP in a follow up PR.

@kaiyan-sheng kaiyan-sheng merged commit cefaeaf into elastic:master Jun 14, 2021
@kaiyan-sheng kaiyan-sheng deleted the disable_packaging_arm branch June 14, 2021 17:37
@mdelapenya
Copy link
Contributor

I think this issue will impact E2E tests running on ARM workers, where we use the elastic-agent ARM image for the stand-alone mode test scenarios. cc/ @EricDavisX

michalpristas added a commit to michalpristas/beats that referenced this pull request Jun 15, 2021
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants