Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test TestAddCounterInvalidArgWhenQueryClosed #27313

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Fix flaky test TestAddCounterInvalidArgWhenQueryClosed #27313

merged 3 commits into from
Aug 11, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 11, 2021

What does this PR do?

Fix flaky test TestAddCounterInvalidArgWhenQueryClosed

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 11, 2021
@botelastic
Copy link

botelastic bot commented Aug 11, 2021

This pull request doesn't have a Team:<team> label.

@narph narph self-assigned this Aug 11, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 11, 2021 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-11T12:35:35.519+0000

  • Duration: 91 min 7 sec

  • Commit: 97fc09d

Test stats 🧪

Test Results
Failed 0
Passed 9610
Skipped 2538
Total 12148

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9610
Skipped 2538
Total 12148

@narph narph merged commit 1a0fb52 into elastic:master Aug 11, 2021
@narph narph deleted the fix-perfmon-test branch August 11, 2021 14:12
@narph narph mentioned this pull request Aug 11, 2021
Merged
6 tasks
@narph narph added the v7.15.0 label Aug 11, 2021
narph added a commit to narph/beats that referenced this pull request Aug 11, 2021
@narph
Fix flaky test TestAddCounterInvalidArgWhenQueryClosed (elastic#27313)
0053629 
* fix flaky test

* changelog

* changelog

(cherry picked from commit 1a0fb52)
narph added a commit that referenced this pull request Aug 12, 2021
@narph
Fix flaky test TestAddCounterInvalidArgWhenQueryClosed (#27313) (#2…
7451823 
…7316)

* fix flaky test

* changelog

* changelog

(cherry picked from commit 1a0fb52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspacca aspacca aspacca approved these changes

Assignees

@narph narph

Labels
needs_team Indicates that the issue/PR needs a Team:* label v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test TestAddCounterInvalidArgWhenQueryClosed
3 participants
@narph @elasticmachine @aspacca