Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metricbeat MongoDB module improvements #2999

Merged
merged 2 commits into from Nov 15, 2016

Conversation

Projects
None yet
2 participants
@tsg
Copy link
Collaborator

commented Nov 14, 2016

Planning the following TODOs:

  • mark fields that are no longer present in 3.4 as optional. #2990
  • add wiredTiger (main) metrics
  • set up integration tests with mongo 3.4
Mark removed fields as optional in MongoDB
Several fields are not reported when the storage engine is set to
wiredTiger, so marking them as optional. Fixes #2990.
@ruflin
Copy link
Collaborator

left a comment

LGTM.

@@ -31,7 +31,7 @@ var schema = s.Schema{
"ms": c.Int("last_ms"),
},
"last_finished": c.Time("last_finished"),
}),
}, c.DictOptional),

This comment has been minimized.

Copy link
@ruflin

ruflin Nov 15, 2016

Collaborator

Nice.

@tsg

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 15, 2016

I'm going to do the dashboards in a separate PR.

@tsg tsg force-pushed the tsg:mongodb_improvements branch from 07594bf to 727e468 Nov 15, 2016

@tsg tsg removed the in progress label Nov 15, 2016

@ruflin
Copy link
Collaborator

left a comment

LGTM

@@ -27,8 +27,8 @@ func TestFetch(t *testing.T) {
available := event["connections"].(common.MapStr)["available"].(int64)
assert.True(t, available > 0)

commits := event["journaling"].(common.MapStr)["commits"].(int64)
assert.True(t, commits >= 0)
page_faults := event["extra_info"].(common.MapStr)["page_faults"].(int64)

This comment has been minimized.

Copy link
@ruflin

ruflin Nov 15, 2016

Collaborator

Variable name is quite python-like ;-)

This comment has been minimized.

Copy link
@tsg

tsg Nov 15, 2016

Author Collaborator

Fixed :)

Add a few hand picked WiredTiger metrics
* Favored a few actionable metrics.
* Use mongo 3.4 in our integration tests

@tsg tsg force-pushed the tsg:mongodb_improvements branch from 727e468 to 7e6452d Nov 15, 2016

@ruflin ruflin merged commit e9a506f into elastic:master Nov 15, 2016

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.