Metricbeat MongoDB module improvements #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several fields are not reported when the storage engine is set to wiredTiger, so marking them as optional. Fixes elastic#2990.
ruflin
reviewed
Nov 15, 2016
| @@ -31,7 +31,7 @@ var schema = s.Schema{ | |||
| "ms": c.Int("last_ms"), | |||
| }, | |||
| "last_finished": c.Time("last_finished"), | |||
| }), | |||
| }, c.DictOptional), | |||
|
I'm going to do the dashboards in a separate PR. |
tsg
force-pushed
the
mongodb_improvements
branch
from
07594bf
to
727e468
Compare
ruflin
reviewed
Nov 15, 2016
| @@ -27,8 +27,8 @@ func TestFetch(t *testing.T) { | |||
| available := event["connections"].(common.MapStr)["available"].(int64) | |||
| assert.True(t, available > 0) | |||
|
|
|||
| commits := event["journaling"].(common.MapStr)["commits"].(int64) | |||
| assert.True(t, commits >= 0) | |||
| page_faults := event["extra_info"].(common.MapStr)["page_faults"].(int64) | |||
There was a problem hiding this comment.
Variable name is quite python-like ;-)
* Favored a few actionable metrics. * Use mongo 3.4 in our integration tests
tsg
force-pushed
the
mongodb_improvements
branch
from
727e468
to
7e6452d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning the following TODOs: