Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually backport filebeat agent spec file fix. #32361

Merged
merged 1 commit into from Jul 18, 2022
Merged

Manually backport filebeat agent spec file fix. #32361

merged 1 commit into from Jul 18, 2022

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jul 14, 2022

This is a manual backport of elastic/elastic-agent#700 to the agent in 7.17

@cmacknz cmacknz added Agent Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jul 14, 2022
@cmacknz cmacknz requested a review from a team as a code owner July 14, 2022 18:55
@cmacknz cmacknz self-assigned this Jul 14, 2022
@cmacknz cmacknz requested review from aleksmaus and michel-laterman and removed request for a team July 14, 2022 18:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 14, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T18:56:01.412+0000

  • Duration: 87 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 1768
Skipped 7
Total 1775

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member Author

cmacknz commented Jul 18, 2022

@michel-laterman do you recognize the E2E test failures here? Can they be ignored?

@cmacknz
Copy link
Member Author

cmacknz commented Jul 18, 2022

Looks like the same E2E tests failed here with an unrelated change: https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/7.17/861/pipeline

I'll merge this today if there is no objection.

@cmacknz cmacknz mentioned this pull request Jul 18, 2022
Merged
jlind23
jlind23 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmacknz cmacknz merged commit 878fc2b into elastic:7.17 Jul 18, 2022
@cmacknz cmacknz deleted the backport-filebeat-spec-fix branch July 18, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@aleksmaus aleksmaus Awaiting requested review from aleksmaus aleksmaus is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@cmacknz cmacknz

Labels
Agent Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmacknz @elasticmachine @jlind23