Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat: Apache2 module #3256

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Dec 29, 2016

Contains filesets for access logs and error logs. It's similar with the Nginx one, although coming with a few challenges of its own.

Sample dashboard:

2017-01-02-09-43-localhost-5601

Will need a rebase on top #3248. Part of #3159.

@tsg tsg added in progress Pull request is currently in progress. review labels Dec 29, 2016
@tsg tsg mentioned this pull request Dec 30, 2016
22 tasks
@tsg tsg removed the in progress Pull request is currently in progress. label Jan 2, 2017
@ruflin ruflin added the Filebeat Filebeat label Jan 2, 2017
@@ -0,0 +1,9 @@
- key: apache2
title: "apache2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably capitalise all titles. We could do this also in the script. @dedemorton did for this some cleanup in Metricbeat.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is created by the generator, which is somehow limited in that regard. Do you mean fixing it up by hand?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it by hand.

example: Chrome
description: >
The name of the user agent.
- name: os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.name, os.major, os.minor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are created by the user agent processor, which is not that flexible when it comes to field names: https://www.elastic.co/guide/en/elasticsearch/plugins/master/using-ingest-user-agent.html

We could maybe do renamings, but I'd say the complexity is not worth it.

- name: os_name
type: keyword
description: >
The name of the operating system.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from os?

"user_agent": {
"major": "50",
"minor": "0",
"os": "Mac OS X 10.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, os contains all info and the other 3 are a split up version. Do we need the split up version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what the processor does by default. I'd stick with that, since if we don't, someone will ask why it's different from LS.

@ruflin
Copy link
Member

ruflin commented Jan 3, 2017

@tsg #3248 is merged. Can you rebase on top?

Contains:
 * access logs fileset, with with_plugins and no_plugins versions
 * error logs fileset
 * Kibana dashboards
@tsg
Copy link
Contributor Author

tsg commented Jan 4, 2017

@ruflin rebased and squashed.

@tsg
Copy link
Contributor Author

tsg commented Jan 4, 2017

jenkins, package it

@tsg
Copy link
Contributor Author

tsg commented Jan 4, 2017

jenkins, test it

@ruflin ruflin merged commit 8b87995 into elastic:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants