Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[functionbeat] [kinesis] use record timestamp instead of current time #33593

Merged
merged 3 commits into from Dec 14, 2022
Merged

[functionbeat] [kinesis] use record timestamp instead of current time #33593

merged 3 commits into from Dec 14, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Nov 7, 2022 •
edited

What does this PR do?

Use record timestamp instead of time.Now() in kinesis events.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@gpop63 gpop63 added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Nov 7, 2022
@gpop63 gpop63 self-assigned this Nov 7, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gpop63? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 7, 2022 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-08T11:33:29.046+0000

  • Duration: 46 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 480
Skipped 6
Total 486

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gpop63 gpop63 force-pushed the fix_functionbeat_kinesis_timestamp branch from c719596 to 2e3dc5c Compare November 7, 2022 12:39
@gpop63 gpop63 marked this pull request as ready for review November 8, 2022 16:57
@gpop63 gpop63 requested a review from a team as a code owner November 8, 2022 16:57
@gpop63 gpop63 requested review from cmacknz and leehinman and removed request for a team, cmacknz and leehinman November 8, 2022 16:57
tommyers-elastic
tommyers-elastic approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpop63 gpop63 merged commit 837c426 into elastic:main Dec 14, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@gpop63 @chrisberkhout
[functionbeat] [kinesis] use record timestamp instead of current time (…
28a0d1d 
…#33593)

* use record timestamp

* add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@gpop63 gpop63

Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Functionbeat] Kinesis timestamp ignored
3 participants
@gpop63 @elasticmachine @tommyers-elastic