Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat] [gcp] add redis metadata #33701

Merged
merged 23 commits into from May 4, 2023
Merged

[metricbeat] [gcp] add redis metadata #33701

merged 23 commits into from May 4, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Nov 16, 2022

What does this PR do?

Adds Redis metadata. Currently, the GCP Redis integration does not provide useful information about the instance e.g. name, type, id (elastic/integrations#4614).

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2022
@gpop63 gpop63 added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Nov 16, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2022
@mergify mergify bot assigned gpop63 Nov 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gpop63? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 16, 2022 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-03T17:34:29.839+0000

  • Duration: 69 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 961
Skipped 1
Total 962

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gpop63
Copy link
Contributor Author

gpop63 commented Nov 23, 2022

/test

1 similar comment
@gpop63
Copy link
Contributor Author

gpop63 commented Nov 24, 2022

/test

@cplow
Copy link

cplow commented Nov 29, 2022

Any update on when the fix is deployed?

@gpop63
Copy link
Contributor Author

gpop63 commented Nov 29, 2022

/test

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b add_gcp-redis_metadata upstream/add_gcp-redis_metadata
git merge upstream/main
git push upstream add_gcp-redis_metadata

@gpop63
Copy link
Contributor Author

gpop63 commented Dec 1, 2022

/test

@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b add_gcp-redis_metadata upstream/add_gcp-redis_metadata
git merge upstream/main
git push upstream add_gcp-redis_metadata

@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b add_gcp-redis_metadata upstream/add_gcp-redis_metadata
git merge upstream/main
git push upstream add_gcp-redis_metadata

@endorama endorama mentioned this pull request Dec 12, 2022
Closed
6 tasks
@endorama
Copy link
Member

@gpop63 if you rebase this I think we can move forward asking the team to test it for regression in the SDK updates.

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

@gpop63 gpop63 marked this pull request as ready for review December 15, 2022 00:37
@gpop63 gpop63 requested review from a team as code owners December 15, 2022 00:37
@gpop63 gpop63 requested review from rdner and faec and removed request for a team December 15, 2022 00:37
rdner
rdner reviewed Jan 4, 2023
View reviewed changes
x-pack/metricbeat/module/gcp/metrics/redis/metadata.go Outdated

if err != nil {
s.logger.Errorf("redis ListInstances error: %v", err)
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check, are you sure it's continue and not break here? How would the loop stop when an error occurs?

@cplow
Copy link

cplow commented Feb 3, 2023

Thank you for looking into this. By any chance, do we know when this issue will be fixed?

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b add_gcp-redis_metadata upstream/add_gcp-redis_metadata
git merge upstream/main
git push upstream add_gcp-redis_metadata

@gpop63
Copy link
Contributor Author

gpop63 commented May 3, 2023

/test

@gpop63 gpop63 merged commit e6f00b4 into elastic:main May 4, 2023
113 checks passed
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@gpop63 @rdner @chrisberkhout
[metricbeat] [gcp] add redis metadata (#33701)
4b48090 
* add redis metadata

* add redis libraries

* update NOTICE.txt

* add changelog entry

* fix linter errors

* fix redis sdk import alias

* update deps

* update NOTICE.txt

* add ListInstances official documentation comment

* use break instead of continue

* fix deps

* fix NOTICE.txt

---------

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner left review comments

@endorama endorama endorama approved these changes

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@gpop63 gpop63

Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gpop63 @elasticmachine @cplow @endorama @rdner