Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packetbeat/procs: don't log at ERROR for file not found #33854

Merged
merged 1 commit into from Dec 1, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 28, 2022

What does this PR do?

This reduces the logging level of ENOENT errors when attempting to map sockets to processes.

Why is it important?

When processes are short lived this spams the logs with unhelpful log lines.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

When processes are short lived this spams the logs with unhelpful log
lines.
@efd6 efd6 self-assigned this Nov 28, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 28, 2022
@efd6 efd6 marked this pull request as ready for review November 29, 2022 00:21
@efd6 efd6 requested a review from a team as a code owner November 29, 2022 00:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-28T23:51:47.375+0000

  • Duration: 48 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 1721
Skipped 19
Total 1740

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit f46b029 into elastic:main Dec 1, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
When processes are short lived this spams the logs with unhelpful log
lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7-candidate backport-skip Skip notification from the automated backport with mergify enhancement Packetbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid packetbeat flooding logs with FindSocketsOfPid errors when on system with short living processes
3 participants