Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable pod events enrichment with deployment name #34097

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This is a "backport" of #28521 so as to support disabling of Deployment metadata enrichment in Pod events.

This will allow us to disable the enrichment that in large clusters can cost a lot and push the k8s API server.

@gizas @tetianakravchenko what do you think?

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark self-assigned this Dec 22, 2022
@ChrsMark ChrsMark requested review from a team as code owners December 22, 2022 12:32
@ChrsMark ChrsMark requested review from fearful-symmetry, faec, AndersonQ and michel-laterman and removed request for a team December 22, 2022 12:32
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 22, 2022
@ChrsMark ChrsMark changed the base branch from main to 7.17 December 22, 2022 12:38
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-22T13:39:54.473+0000

  • Duration: 84 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 22222
Skipped 1562
Total 23784

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Namespace: metaCfg,
Node: metaCfg,
Namespace: metaCfg,
Deployment: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this be false?

Copy link
Member Author

@ChrsMark ChrsMark Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to this, it works like "true" be default so we need to preserve it as is and just give the option to disable it when users actually need this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
just one documentation comment

libbeat/docs/shared-autodiscover.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ChrsMark
Copy link
Member Author

I have tested locally the changes to verify we don't miss anything important with this backport. Everything works as expected:

deployment: true (default state)
rs-dep1

deployment: false
rs-dep2

@ChrsMark ChrsMark merged commit 71da5d8 into elastic:7.17 Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants