Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new timestamp format #34211

Merged
merged 17 commits into from Feb 1, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Jan 9, 2023

  • Enhancement

What does this PR do?

This PR supports RabbitMQ new timestamp format with nanosecond precision and timezone "2022-03-23 13:16:58.000369+03:00".
Previous timestamp format "2019-04-12 10:11:15.094".
New DATETIME pattern is replaced by TIMESTAMP_ISO8601.

Why is it important?

This change is required as latest rabbitmq version switched to new default timestamp format.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ritalwar? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-01T14:40:05.447+0000

  • Duration: 76 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 7241
Skipped 746
Total 7987

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ritalwar ritalwar marked this pull request as ready for review January 16, 2023 10:53
@ritalwar ritalwar requested a review from a team as a code owner January 16, 2023 10:53
@@ -1,6 +1,6 @@
[
{
"@timestamp": "2019-04-03T11:13:15.076-02:00",
"@timestamp": "2023-01-03T05:20:19.811-02:00",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no difference in the @timestamp format before vs after?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @timestamp field is parsed from timestamp field, the actual change is in timestamp field.

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rabbitmq_timestamp_filebeat_2905 upstream/rabbitmq_timestamp_filebeat_2905
git merge upstream/main
git push upstream rabbitmq_timestamp_filebeat_2905

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rabbitmq_timestamp_filebeat_2905 upstream/rabbitmq_timestamp_filebeat_2905
git merge upstream/main
git push upstream rabbitmq_timestamp_filebeat_2905

@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rabbitmq_timestamp_filebeat_2905 upstream/rabbitmq_timestamp_filebeat_2905
git merge upstream/main
git push upstream rabbitmq_timestamp_filebeat_2905

2023-01-24 10:38:49.525012+00:00 [info] <0.723.0> Ready to start client connection listeners
2023-01-24 10:38:49.525875+00:00 [info] <0.868.0> started TCP listener on [::]:5672
completed with 4 plugins.
2023-01-24 10:38:49.664998+00:00 [info] <0.723.0> Server startup complete; 4 plugins started.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these messages are missing in the expected.json file, please check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@ritalwar ritalwar merged commit d56d340 into elastic:main Feb 1, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* add support for new timestamp format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants