Deprecate filebeat.config_dir config option #3429
Conversation
|
Is it really helpful to deprecate it without an alternative? |
|
We should definitively deprecate it in 5.3 to make sure we can remove / change it in 6.0. Deprecating does not necessarily mean we will remove it. I would also not remove it before we have a replacement. Here is a follow up Github issue to discuss the new configs: #3430 |
CHANGELOG.asciidoc
Outdated
| @@ -111,6 +111,7 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff] | |||
| - Fix error on importing dashboards due to colons in the Caassandra dashboard. {issue}3140[3140] | |||
|
|
|||
| *Filebeat* | |||
| - Config option `filebeat.config_dir` is deprecated. It is planned to replace it with a new implementation. | |||
There was a problem hiding this comment.
I suggest: "Config option filebeat.config_dir is deprecated. It will be replaced in version 6.0 with a new implementation that also supports configuration reloading"
There was a problem hiding this comment.
SGTM. I'm confident enough in #3430 to get it in for 6.0
The plan is replace this with a better implementation in the future similar to prospector reloading. See elastic#3362.
ruflin
force-pushed
the
deprecate-config-dir
branch
from
dd2367c
to
1841ca3
Compare
|
@ruflin Can you please update this PR? Thanks! |
|
@tsg @monicasarbu I suggest to open this PR against 5.x to deprecate it there. And for master a PR is needed that does remove the old implementation and switches it over the new reload configuration. |
The plan is replace this with a better implementation in the future similar to prospector reloading. See #3362.