Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filebeat/input/tcp: add support for TCP input metrics #34333

Merged
merged 2 commits into from Jan 24, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 23, 2023

What does this PR do?

This adds metrics for TCP packet count and total bytes, and histograms for time required to process TCP packets prior to acking from a publication and time between TCP packet arrivals.

Why is it important?

This allows us to help users configure their systems to match the requirements that they have.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.7-candidate labels Jan 23, 2023
@efd6 efd6 self-assigned this Jan 23, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 23, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-23T02:06:21.982+0000

  • Duration: 73 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 7204
Skipped 742
Total 7946

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review January 23, 2023 03:35
@efd6 efd6 requested a review from a team as a code owner January 23, 2023 03:35
@efd6 efd6 requested review from cmacknz and fearful-symmetry and removed request for a team January 23, 2023 03:35
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 requested a review from a team January 23, 2023 04:04
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 5ed9f16 into elastic:main Jan 24, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* convert to v2 input
* add input metrics support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants