Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IIS] Remove beta warning from application_pool metricset #35480

Merged
merged 14 commits into from May 23, 2023

Conversation

muthu-mps
Copy link
Contributor

  • Bug

What does this PR do?

Relates to this issue #35061

How to test this PR locally

  • Install IIS metricbeat module
  • Enable application_pool metrics collection
  • Verify there is no beta warnings.

Related issues

@muthu-mps muthu-mps added the Team:Service-Integrations Label for the Service Integrations team label May 16, 2023
@muthu-mps muthu-mps self-assigned this May 16, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 16, 2023
@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @muthu-mps? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-23T11:13:40.190+0000

  • Duration: 61 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 1398
Skipped 90
Total 1488

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@muthu-mps muthu-mps marked this pull request as ready for review May 16, 2023 12:37
@muthu-mps muthu-mps requested a review from a team as a code owner May 16, 2023 12:37
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me but the PR title seems a little off. Suggestion:

[IIS] Remove beta warning from application_pool metricset

^^ is similar to the title of the issue linked.

@muthu-mps muthu-mps changed the title [IIS] Application pool metric-set remove the beta warning [IIS] Remove beta warning from application_pool metricset May 18, 2023
@muthu-mps muthu-mps requested a review from shmsr May 18, 2023 07:07
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry missing in the changelog. Could you please add it?

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muthu-mps muthu-mps merged commit 3bc0b3c into elastic:main May 23, 2023
21 checks passed
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* remove beta warning

* Added changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat IIS] Remove Beta warning flag from application_pool.
5 participants