Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/awss3: relax queue_url constraints for non-standard endpoints #35520

Merged
merged 6 commits into from Jun 8, 2023
Merged

x-pack/filebeat/input/awss3: relax queue_url constraints for non-standard endpoints #35520

merged 6 commits into from Jun 8, 2023

Commits on Jun 8, 2023

  1. x-pack/filebeat/input/awss3: relax queue_url constraints for testing 

    Currently, the queue_url option is used to obtain the region name for
the SQS receiver. This prevents pointing the input at other sources for
testing, so add a region_name option to provide an alternative way to
provide the region name for non-AWS endpoints.

To avoid confusion, prevent using the region_name option in conjunction
with amazonaws.com endpoints and document this.
    @efd6
    efd6 committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    69aa0d6 View commit details
    Browse the repository at this point in the history

  2. address pr comment 

    Also improve comprehensability of test cases.
    @efd6
    efd6 committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b30fc06 View commit details
    Browse the repository at this point in the history

  3. address pr comment

    @efd6
    efd6 committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    895f935 View commit details
    Browse the repository at this point in the history

  4. address pr comments

    @efd6
    efd6 committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    fb955e5 View commit details
    Browse the repository at this point in the history

  5. ignore empty region name

    @efd6
    efd6 committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8752c3e View commit details
    Browse the repository at this point in the history

  6. address pr comment 

    Make getRegionFromQueueURL aware of configured region name, this means
that it will return either a non-zero region name or a non-nil error.
    @efd6
    efd6 committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    0fc0ab5 View commit details
    Browse the repository at this point in the history