-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debounce input reload on autodiscover #35645
Merged
belimawr
merged 15 commits into
elastic:main
from
belimawr:fix-input-reload-autodiscover
Jun 20, 2023
Merged
Debounce input reload on autodiscover #35645
belimawr
merged 15 commits into
elastic:main
from
belimawr:fix-input-reload-autodiscover
Jun 20, 2023
Commits on Jun 19, 2023
-
Debounce input reload on Kubernetes autodiscover
The Kubernetes autodiscover feature now incorporates a debounce logic when reloading inputs. By default, it waits for at least 1 second before invoking the Reload method. In case of an error, it introduces a 10-second delay before retrying. The channel used for test synchronisation has been removed and tests now use (assert/require).Eventually. When Autodiscover calls `cfgfile.NewRunnerList` to instantiate a RunnerList, it now specifies a different logger name, enabling more granular log filtering. Debug logs now provide information about the reasons for invoking Reload. Certain tests that perform sequential actions now utilise `require` instead of `assert` to maintain a consistent state avoid cascading failures. Tests that required updates now leverage `require.Eventually` instead of `wait`, providing additional information on failure causes. Documentation for `cfgfile.RunnerList` has been improved to enhance clarity.
Configuration menu - View commit details
-
Copy full SHA for a602e0b - Browse repository at this point
Copy the full SHA a602e0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1507d3 - Browse repository at this point
Copy the full SHA f1507d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1a541d - Browse repository at this point
Copy the full SHA b1a541dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e127631 - Browse repository at this point
Copy the full SHA e127631View commit details -
This tests seems flaky on CI, increasing the timeout might help.
Configuration menu - View commit details
-
Copy full SHA for f842cb4 - Browse repository at this point
Copy the full SHA f842cb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 135223e - Browse repository at this point
Copy the full SHA 135223eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1ff90b - Browse repository at this point
Copy the full SHA b1ff90bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1370448 - Browse repository at this point
Copy the full SHA 1370448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 992cc1c - Browse repository at this point
Copy the full SHA 992cc1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed78bb7 - Browse repository at this point
Copy the full SHA ed78bb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15983ac - Browse repository at this point
Copy the full SHA 15983acView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd830a9 - Browse repository at this point
Copy the full SHA dd830a9View commit details -
add tests to ensure the changes actually work
Test the case when handle(Start|Stop) is called multiple times and on at least on the last one they return false.
Configuration menu - View commit details
-
Copy full SHA for 9b85c3b - Browse repository at this point
Copy the full SHA 9b85c3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e67e829 - Browse repository at this point
Copy the full SHA e67e829View commit details
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 87e8eee - Browse repository at this point
Copy the full SHA 87e8eeeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.