Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the unit unhealthy if output fails to start #35719

Merged
merged 6 commits into from
Jun 13, 2023
Merged

Set the unit unhealthy if output fails to start #35719

merged 6 commits into from
Jun 13, 2023

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Jun 8, 2023 •
edited
Loading

What does this PR do?

It fixes the status reporting when the output fails to start under Elastic-Agent and also prevents some deadlock conditions on inputs that will block its initialisation when the output is not ready.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Author's Checklist

How to test this PR locally

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr added the bug label Jun 8, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 8, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-12T09:38:55.150+0000

  • Duration: 79 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 8070
Skipped 370
Total 8440

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@belimawr
Set the unit unhealthy if output fails to start
ad41e11 
If the output fails to start some inputs will go into a deadlock
state, so we set the output unit as unhealthy and return early from
the reload process.
@belimawr
clean up tests
8b762a4
@belimawr
Unit tests
be9b4e8
@belimawr
Improve changelog
316cddd
@belimawr
Small improvements
02ee547
@belimawr belimawr marked this pull request as ready for review June 9, 2023 16:12
@belimawr belimawr requested a review from a team as a code owner June 9, 2023 16:12
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jun 9, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2023
@pierrehilbert pierrehilbert requested review from rdner and removed request for pierrehilbert June 9, 2023 16:14
@belimawr belimawr requested a review from leehinman June 12, 2023 09:38
leehinman
leehinman approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@belimawr belimawr merged commit 1cbb9ad into elastic:main Jun 13, 2023
54 of 56 checks passed
@belimawr belimawr deleted the fix-unhealthy-output branch June 13, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@rdner rdner Awaiting requested review from rdner

Assignees

@belimawr belimawr

Labels
bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agents remain unhealthy on switching from invalid output to valid output.
4 participants
@belimawr @elasticmachine @leehinman @pierrehilbert