-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Deployment condition status metric in Kubernetes module #35999
Changes from 5 commits
dc09727
dc7df0a
ac1d127
6f59712
02d101f
91cdc3d
4478e0c
39285a8
7c59449
c241465
743eb56
c789e83
07005c5
b3db4cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,10 @@ | |
"MetricSetFields": { | ||
"name": "coredns", | ||
"paused": false, | ||
"status": { | ||
"available": "true", | ||
"progressing": "true" | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This bracket should be one layer in, right? Like https://github.com/elastic/beats/pull/35999/files#diff-050ad6dbacd48af0a47953cade64df8f81c2104c232ddc15dfc1feff29d48badR40-R43. Same for the rest of them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Blew my brain :) Fixed thanks @ChrsMark |
||
"replicas": { | ||
"available": 2, | ||
"desired": 2, | ||
|
@@ -77,4 +81,4 @@ | |
"Period": 0, | ||
"DisableTimeSeries": false | ||
} | ||
] | ||
] |
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -32,7 +32,23 @@ var mapping = &p.MetricsMapping{ | |||||||||||||
"kube_deployment_status_replicas_unavailable": p.Metric("replicas.unavailable"), | ||||||||||||||
"kube_deployment_status_replicas_available": p.Metric("replicas.available"), | ||||||||||||||
"kube_deployment_spec_replicas": p.Metric("replicas.desired"), | ||||||||||||||
"kube_deployment_spec_paused": p.BooleanMetric("paused"), | ||||||||||||||
/* | ||||||||||||||
This is how deployment_status_condition field will be exported: | ||||||||||||||
|
||||||||||||||
kube_deployment_status_condition{namespace="default",deployment="test-deployment",condition="Available",status="true"} 0 | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it should be enough to add it in corresponding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is already there see line 222 It is more alligned to this comment: beats/metricbeat/module/kubernetes/state_job/state_job.go Lines 41 to 46 in ac1d127
I found it helpful when first looked the code, because you can not understand how the p.LabelMatric works from first glance. Let me know if you think is obsolete and I can remove it |
||||||||||||||
kube_deployment_status_condition{namespace="default",deployment="test-deployment",condition="Available",status="false"} 1 | ||||||||||||||
kube_deployment_status_condition{namespace="default",deployment="test-deployment",condition="Available",status="unknown"} 0 | ||||||||||||||
kube_deployment_status_condition{namespace="default",deployment="test-deployment",condition="Progressing",status="true"} 1 | ||||||||||||||
kube_deployment_status_condition{namespace="default",deployment="test-deployment",condition="Progressing",status="false"} 0 | ||||||||||||||
kube_deployment_status_condition{namespace="default",deployment="test-deployment",condition="Progressing",status="unknown"} 0 | ||||||||||||||
*/ | ||||||||||||||
"kube_deployment_status_condition": p.LabelMetric("status", "status", p.OpFilterMap( | ||||||||||||||
"condition", map[string]string{ | ||||||||||||||
"Progressing": "progressing", | ||||||||||||||
"Available": "available", | ||||||||||||||
}, | ||||||||||||||
)), //The current status conditions of a deployment | ||||||||||||||
"kube_deployment_spec_paused": p.BooleanMetric("paused"), | ||||||||||||||
}, | ||||||||||||||
|
||||||||||||||
Labels: map[string]p.LabelMap{ | ||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a breaking change. Hence it should go in
==== Added
section.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed