Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/processors/decode_def/cef: relax size constraint on network bytes #36108

Merged
merged 1 commit into from Jul 20, 2023
Merged

x-pack/filebeat/processors/decode_def/cef: relax size constraint on network bytes #36108

merged 1 commit into from Jul 20, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 19, 2023

What does this PR do?

Relax the width of in and out fields from integer to long to allow values greater beyond 2GiB.

Why is it important?

2GiB is unreasonably small.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify 8.10-candidate labels Jul 19, 2023
@efd6 efd6 self-assigned this Jul 19, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2023
@efd6
x-pack/filebeat/processors/decode_def/cef: relax size constraint on n…
84163ae 
…etwork bytes

Relax the width of in and out fields from integer to long to allow
values greater beyond 2GiB.
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-19T03:03:30.261+0000

  • Duration: 73 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 3054
Skipped 178
Total 3232

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review July 19, 2023 04:20
@efd6 efd6 requested a review from a team as a code owner July 19, 2023 04:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 9f28394 into elastic:main Jul 20, 2023
21 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
x-pack/filebeat/processors/decode_def/cef: relax size constraint on n…
1200172 
…etwork bytes (elastic#36108)

Relax the width of in and out fields from integer to long to allow
values greater beyond 2GiB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
8.10-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[decode_cef] Allow int64 (instead of int32) for bytesIn, bytesOut
3 participants
@efd6 @elasticmachine @andrewkroh