Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fortinet/firewall] Add network processor in addition to interface based direction resolution. #37023

Merged
merged 1 commit into from Nov 6, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 3, 2023

Proposed commit message

Adds network processor in addition to interface based direction resolution.
In some cases the current interface based logic was not enough to resolve properly or it directly failed with the wrong values.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 3, 2023
@mergify mergify bot assigned marc-gr Nov 3, 2023
Copy link
Contributor

mergify bot commented Nov 3, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @marc-gr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@marc-gr marc-gr force-pushed the fix/fortinet-fw-network.direction branch from 471f0c8 to 9a8a17d Compare November 3, 2023 09:36
@marc-gr marc-gr requested a review from a team as a code owner November 3, 2023 09:36
@marc-gr marc-gr added 8.12 candidate backport-skip Skip notification from the automated backport with mergify Filebeat Filebeat labels Nov 3, 2023
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 3, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-03T09:36:45.684+0000

  • Duration: 137 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 3231
Skipped 176
Total 3407

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit ed34c37 into elastic:main Nov 6, 2023
20 checks passed
@marc-gr marc-gr deleted the fix/fortinet-fw-network.direction branch November 6, 2023 09:02
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.12 candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants