Move removal of files to clean #3726
Conversation
This makes sure all generated files are removed on clean and not before they are regenerated.
| rm -rf _meta/kibana/dashboard _meta/kibana/search _meta/kibana/visualization | ||
| # Clean module docs | ||
| rm -rf docs/modules | ||
|
|
||
| # Collects all module dashboards | ||
| .PHONY: kibana | ||
| kibana: |
There was a problem hiding this comment.
Should then kibana depend on clean? Otherwise I'm afraid we might get old dashboards mixed with the new ones.
There was a problem hiding this comment.
I'm kind of undecided on this PR now looking at it again. It's nice that all clean is one place but at the same time it then requires kibana to depend on clean which I don't like. We should not get old dashboards because of CI always starts on a fresh build and would detect the old files.
There was a problem hiding this comment.
Hmm, yeah, still feels risky to me. Maybe separate a kibana-clean target on which both clean and kibana depend?
|
@tsg I went for duplicating the code instead of introducing an additional target. The important part in this PR is that |
This makes sure all generated files are removed on clean and not before they are regenerated.