Join GitHub today
New module windows for metricbeat #3758
1 similar comment
Mar 16, 2017
andrewkroh left a comment •
Thanks for opening up a PR for this.
I left some minor feedback about error handling. After you address that I'll probably take the code for a test drive.
Could you please add some tests (like a
It looks like you accidentally committed a copy of
ruflin left a comment
Thanks a lot for taking this on. Having platform specific modules is something new in metricbeat.
I'm not too happy about the metricset name yet, but I couldn't come up with an alternative name yet.
Any chance you could share some example outputs for the example config you created. I'm curious to see how the events will look.
I left you a few comments which are mostly related to the assumption, that this is a dynamic metricset.
Hi @ruflin, here is an example output
@maddin2016 Could you update the CHANGELOG.asciidoc ? About the config options structure not sure what we should do. Would like to get the input from @andrewkroh too. I tend to the in the direction of the "flatter" one as it makes the code simpler and has less indentations to get wrong, but we loose the grouping concept. The nice thing about having it in beat, we still have the possibility to change it later in case we see people use it very differently.
@maddin2016 All green, great! So we are going to merge this is and would like to iterate on it with some additional (smaller) PRs. We're starting a meta issue to track some changes to the module. Hopefully you can help us with these changes. Thanks for the contribution!!